Feature/convert to npm #89
Conversation
… global var Space.log
…rlying library for Space.Logger
… multiple logging adapters in Space.Logger, adds adapter for console, winston logging libraries, wires everything up in module.coffee
…ds setMinLevel, adds removable transports at winston adapter
…eparing logging configuration
…ntained in additional packages
…eature/logger-refactor # Conflicts: # package.js
underscore, check -> simplecheck
… tests, ensures that Babel is running locally; Removes unused Babel plugins and updates .babelrc
| // Publishes a module into the space environment to make it | ||
| // visible and requireable for other modules and the application | ||
| publish(module, identifier) { | ||
| // TODO: its overriding name necessary? |
There was a problem hiding this comment.
This property can't be assigned do to TypeError: Cannot assign to read only property 'name' of function 'function GrandchildModule() { initialize.apply(this, arguments); }', unclear about approach here.
| version: 0.10.33 | ||
| pre: | ||
| - curl https://install.meteor.com | /bin/sh | ||
| version: 6.0.0 |
There was a problem hiding this comment.
Do to:
for (let [index, struct] of ObjectEntries(actual)) {
^^
SyntaxError: Unexpected identifier
Can't figure out why this works above 6.0.0, tried 4.0.0, 5.0.0 and one from 0.10.* - no luck. This should work on those versions. babel/babel#5041
|
|
||
| // @backward {space:base} <= 4.1.3 for Meteor package, | ||
| // Give every module access Npm | ||
| if (!isNil(Meteor) && this._isServer() && !isNil(Npm)) { |
There was a problem hiding this comment.
I think this could be extracted to predefined dependencies. Such, would be added via static method on Module.addPredefinedDependency/Module.setPredefinedDependencisthat would allow space-base be framework agnostic - however still, allow to add separate framework-oriented dependencies with all sugary goodnes out of the box.
This would result in Meteor adding default mappings like it was done previously here:
_mapMeteorApis: ->
@injector.map('Meteor').to Meteor
if Package.ejson?
@injector.map('EJSON').to Package.ejson.EJSON
if Package.ddp?
@injector.map('DDP').to Package.ddp.DDP
if Package.random?
@injector.map('Random').to Package.random.Random
@injector.map('underscore').to Package.underscore._
if Package.mongo?
@injector.map('Mongo').to Package.mongo.Mongo
if Meteor.isServer
@injector.map('MongoInternals').to Package.mongo.MongoInternals
if Meteor.isClient
if Package.tracker?
@injector.map('Tracker').to Package.tracker.Tracker
if Package.templating?
@injector.map('Template').to Package.templating.Template
if Package.session?
@injector.map('Session').to Package.session.Session
if Package.blaze?
@injector.map('Blaze').to Package.blaze.Blaze
if Meteor.isServer
@injector.map('check').to check
@injector.map('Match').to Match
@injector.map('process').to process
@injector.map('Future').to Npm.require 'fibers/future'
if Package.email?
@injector.map('Email').to Package.email.Email
if Package['accounts-base']?
@injector.map('Accounts').to Package['accounts-base'].Accounts
if Package['reactive-var']?
@injector.map('ReactiveVar').to Package['reactive-var'].ReactiveVar```
| this.injector.map('log').to(this.log); | ||
| }, | ||
|
|
||
| _isServer() { |
There was a problem hiding this comment.
Ensure that this is working as intended with webpack on client and server.
Will review code again to get all quirks here commented in few days.