Mf/202501 optimize strip #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use a few "register" variables for likely hot spots - stop tracking the sgrs[] as we mostly don't care about previous values (i.e. was there a "1;"?) if we're stripping ANSI: all we care is really about finding the ending "m" and _verifying_ (but we could drop that) that each number in the ";" sequence is 0-255. - rearrange the switch() into a series of if/else roughly based on how prevalent it ought to be in a common ANSI text input. Feeding this my usual 50M-100M-1G-1.5G ANSI-laden files, both "normal" (from an ANSI telnet-based MUD) and "pernicious" where basically every character or so is a different color, this speeds things up in the region of 2-7% depending. Files without ANSI don't get any particular speed-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just_strip_it: rearrange to speed things up
Feeding this my usual 50M-100M-1G-1.5G ANSI-laden files, both "normal" (from an ANSI telnet-based MUD) and "pernicious" where basically every character or so is a different color, this speeds things up in the region of 2-7% depending.
Files without ANSI don't get any particular speed-up.