Skip to content

Conversation

@adamiwaniuk
Copy link
Contributor

Thanks for this project! I found this when trying to implement control over my ventilation via Google Home and this is very helpful.
While running aiocomfoconnect register it hangs on my machine.
I think this is bug introduced while implementing reconnect logic.
When exception ComfoConnectNotAllowed is thrown, it will be dropped and await connected will hang until time out.
And then code

except ComfoConnectNotAllowed:
        # We probably are not registered yet...
        try:
            await comfoconnect.cmd_register_app(uuid, name, pin)

will not be executed, so app will never register.
After this fix I can register and use this module properly.

@michaelarnauts
Copy link
Owner

This makes sense! Thanks a lot for the fix!

@michaelarnauts michaelarnauts merged commit 10a82f5 into michaelarnauts:master Jan 22, 2025
3 checks passed
sfo2001 pushed a commit to sfo2001/aiocomfoconnect that referenced this pull request Jun 20, 2025
Co-authored-by: Adam h1Iwaniuk/h1 <adamiwaniuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants