Fix false positives for SPM packages using custom path: argument #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The tool produced false positives for SPM packages that use custom path: arguments in their target definitions. When Sources/TargetName didn't exist, it fell back to scanning ALL of Sources/ and attributed every file to that target.
Example: A package with:
.target(name: "MyModule", path: "Sources/Core")
.target(name: "MyModuleUI", path: "Sources/UI")
Would look for Sources/MyModule, not find it, fall back to Sources/, scan all files, and report UI code as violations for MyModule.
Solution:
Added
path: String?property to SwiftPackageTarget to store custom paths from target definitionsUpdated PackageSwiftFileVisitor to parse the path: argument from SPM target function calls using SwiftSyntax
Modified PackagesParser to:
customPathNotFounderror if custom path doesn't exist (prevents silent false positives from scanning zero files)Tests:
🤖 Generated with Claude Code