-
Notifications
You must be signed in to change notification settings - Fork 6
fix ruamel and pandas api #93
base: main
Are you sure you want to change the base?
Conversation
|
@ischoegl not all tests are passing but I made a good part of the way already, I'd like your input on the remaining failures (see "Final To-Do") |
|
@erwanp ... thanks for the PR! I really appreciate it! As Cantera 3.1 was released recently, there are likely some changes that need more work. I won't be able to look into this until the second half of January. |
|
No problem. Just for information, all the tests above have been done with Cantera 3.1.0 |
|
Hello @ischoegl any time to look at this ? |
|
Sorry that it is taking longer than anticipated. I hope to get a look at this later this week. |
"(if X and pd.Series) was creating ambiguity errors in the evaluation of True/False of the Series"
|
@erwanp ... sorry that it took another long while before I could get back here. This repo is still based on Cantera 2.4, and the storage format I prototyped here predates the now standard HDF format I implemented in main Cantera since. Overall, the code would require major refactoring, which I don't have the bandwidth for. While I believe that the tool still has a purpose, I decided to archive as maintaining it outside of Cantera is not sustainable. Please post a feature request on Cantera/enhancements in case you'd like to see this capability become available there. |
API updates
https://yaml.readthedocs.io/api/#transparent-usage-of-new-and-old-api
Fixes #92
Also :
pkg_resourcespintResult
List of Tests :
pytest .Detail :
Details
Summary of failures :
Final To-Do
AssertionError: 1 is not falseof failing TestNotebooks