Skip to content

Load source maps in mergebot #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jakebailey wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Load source maps in mergebot #1033

jakebailey wants to merge 1 commit into from

Conversation

@jakebailey
Copy link
Member

@jakebailey jakebailey commented Jul 12, 2024

To aid in debugging crashes.

@jakebailey
Copy link
Member Author

jakebailey commented Jul 12, 2024

Alternatively we can set languageWorkers__node__arguments=--enable-source-maps on Azure.

@jakebailey
Copy link
Member Author

jakebailey commented Jul 12, 2024

I tried setting:

--source-root=https://raw.githubusercontent.com/microsoft/DefinitelyTyped-tools/main/packages/mergebot/dist

Per https://esbuild.github.io/api/#source-root, but that doesn't work with source-map-support, only with Node's --enable-source-maps. Hmmm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandersn sandersn sandersn approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch andrewbranch is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakebailey @sandersn