fix(minillm): qwen2 teacher student model unmatched model vocab size #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
When distilling from teacher model
Qwen/Qwen2.5-7B-Instructto student modelQwen/Qwen2.5-3B, mismatched model vocab size issue.Description of Change
Though both model has same tokenizer vocab size of
151665, their model vocab size (embedding) are different whereQwen/Qwen2.5-7B-Instructhas152064andQwen/Qwen2.5-3Bhas151936. It is safe to truncate the extra padded tokens from the teacher logits (as no real token ID points to them).Added a conditional fix to handle Qwen2 model types where vocab size mismatch may occur. The change ensures that teacher logits are truncated to match the student’s vocabulary size before loss computation.