-
Notifications
You must be signed in to change notification settings - Fork 11
Make docs RST format and add more details for public facing methods #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR converts all docstrings from NumPy-style format to Sphinx reStructuredText (reST) format with field lists. The changes affect module-level documentation, class docstrings, and method docstrings across the SDK's public API.
Key Changes:
- Replaced NumPy-style docstrings (Parameters/Returns/Raises sections) with Sphinx field list syntax (
:param:,:type:,:return:,:rtype:,:raises:) - Added comprehensive module-level docstrings with usage examples
- Enhanced class and method documentation with detailed parameter descriptions and examples
- Added cross-references using Sphinx roles (
:class:,:meth:)
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/dataverse_sdk/__init__.py |
Added package-level docstring with features, usage example, and Azure Identity note |
src/dataverse_sdk/client.py |
Converted DataverseClient class and all method docstrings to Sphinx format with extensive examples |
src/dataverse_sdk/config.py |
Added docstrings for DataverseConfig class and from_env method |
src/dataverse_sdk/auth.py |
Added docstrings for TokenPair and AuthManager classes |
src/dataverse_sdk/errors.py |
Added comprehensive docstrings for all exception classes |
src/dataverse_sdk/odata_pandas_wrappers.py |
Converted pandas wrapper docstrings and added module-level documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This pull request adds comprehensive docstrings and improves documentation across several modules in the Dataverse SDK for Python. The changes clarify the purpose, usage, and parameters of key classes and methods, making the codebase more accessible and maintainable for future contributors and users.
Documentation improvements:
src/dataverse_sdk/__init__.pydescribing the SDK's features, authentication requirements, and usage example.TokenPair,AuthManager, and its methods) insrc/dataverse_sdk/auth.py, specifying parameter types, exceptions, and usage. [1] [2]Error handling documentation:
src/dataverse_sdk/errors.py, includingDataverseError,ValidationError,MetadataError,SQLParseError, andHttpError, with details on parameters and error context. Also added documentation to methods liketo_dict. [1] [2] [3]Configuration documentation:
DataverseConfigclass and itsfrom_envmethod insrc/dataverse_sdk/config.py, explaining configuration options and defaults. [1] [2]Pandas integration documentation:
src/dataverse_sdk/odata_pandas_wrappers.pywith a concise description of its purpose and main class. Improved docstrings for theRowErrorandPandasODataClientclasses and all CRUD/query methods, specifying parameter types, return values, and error handling. [1] [2] [3] [4] [5] [6]