add solution association in create table #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for associating newly created custom tables with a specific solution in Dataverse by introducing an optional solution_unique_name parameter to the create_table method.
- Added
solution_unique_nameparameter tocreate_tableand_create_entitymethods - Added input validation to ensure
solution_unique_nameis a non-empty string when provided - Updated documentation and examples to demonstrate the new parameter
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/dataverse_sdk/odata.py | Added solution_unique_name parameter to _create_entity and _create_table methods with validation logic |
| src/dataverse_sdk/client.py | Added solution_unique_name parameter to public create_table method with updated docstring |
| README.md | Updated API reference table and example to document the new solution_unique_name parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tpellissier-msft
previously approved these changes
Nov 5, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tpellissier-msft
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for associating newly created tables with a specific solution in the Dataverse SDK, rather than always using the default solution. This is achieved by introducing an optional
solution_unique_nameparameter to thecreate_tablemethod and propagating this through the relevant layers of the codebase. Documentation and usage examples have also been updated to reflect this new capability.API and Functionality Enhancements:
Added an optional
solution_unique_nameparameter to thecreate_tablemethod inclient.py, allowing users to specify which solution should own the new custom table. This parameter is validated to ensure it is a non-empty string if provided. [1] [2] [3] [4] [5]Updated the lower-level
_create_entityand_create_tablemethods inodata.pyto accept and correctly use thesolution_unique_nameparameter, passing it as a query parameter in the API request if specified. [1] [2] [3] [4]Documentation Updates:
README.mdto document the newsolution_unique_nameparameter forcreate_table, including an example usage showing how to associate a table with a specific solution. [1] [2]