user/tpellissier/fix-get-single-select #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the API consistency of the _get method by changing the select parameter from a comma-separated string to a list of column names. This aligns the internal implementation with the public API expectation in DataverseClient.get(), which already accepts select as a list.
Key Changes:
- Updated
_getmethod signature to acceptselect: Optional[List[str]]instead ofOptional[str] - Modified implementation to join the list elements with commas when constructing the
$selectquery parameter - Updated docstring to reflect the new parameter type using consistent numpy-style documentation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sagebree
reviewed
Nov 13, 2025
zhaodongwang-msft
previously approved these changes
Nov 13, 2025
tpellissier-msft
force-pushed
the
user/tpellissier/fix-get-single-select
branch
from
794d7ab to
4d5425b
Compare
zhaodongwang-msft
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
_getmethod insrc/PowerPlatform/Dataverse/data/odata.pyto improve how selected columns are specified when retrieving a single record. Instead of passing a comma-separated string, the method now expects a list of column names, which it joins into the required format for the$selectparameter.API usability improvements:
selectparameter in the_getmethod from a comma-separated string to a list of column names, making the API easier and safer to use. (src/PowerPlatform/Dataverse/data/odata.py) [1] [2]