Add unit tests for DataverseClient #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comprehensive unit tests for the DataverseClient class in tests/unit/test_client.py. These tests mock the internal _ODataClient to verify that the public API methods (create, get, update, delete) correctly delegate to the underlying OData implementation.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit tests for the DataverseClient class, which previously lacked direct test coverage. The tests use mocking to isolate the client logic from network calls and verify that public API methods correctly delegate to the underlying _ODataClient.
- Added 8 unit tests covering Create, Read, Update, and Delete operations for both single and multiple records
- Used
unittest.mockto mock the internal_ODataClientfor isolated testing - Verified proper delegation of method calls with correct parameters
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
zhaodongwang-msft
approved these changes
Dec 17, 2025
Collaborator
|
merged it. @masachika-kamada thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds unit tests for the
DataverseClientclass intests/unit/test_client.py.Motivation
Currently,
DataverseClientlacks direct unit tests. These tests ensure that the public API methods (create,get,update,delete) correctly delegate operations to the underlying_ODataClient.Changes
tests/unit/test_client.pyunittest.mockto isolateDataverseClientlogic from network calls.Verification
pytest tests/unit/test_client.pyand confirmed all 8 tests passed.ruffandblackto ensure code style compliance.