Update to 0.1.3.4 #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix multiple bugs 1. Sometimes TraceGraph does not follow heap ordering. 2. When @Bundle(trainable=True) is applied to a class method, different class instances will unintentionally share the same parameter. 3. When calling @Bundle class method(s) multiple times of a class instance, duplicated nodes of the class instance are created, which all point to the same class instance. 4. When accessing the bundled method of a class instance, it returns a partial function instead of FunModule, which makes accessing properties of the bundled method difficult.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes multiple bugs.
Sometimes TraceGraph does not follow heap ordering (previous commit 6c4c52d)
When @Bundle(trainable=True) is applied to a class method, different class instances will unintentionally share the same parameter.
When calling @Bundle class method(s) multiple times of a class instance, duplicated nodes of the class instance are created, which all point to the same class instance.
When accessing the bundled method of a class instance, it returns a partial function instead of FunModule, which makes accessing properties of the bundled method difficult.