Skip to content

Conversation

@chinganc
Copy link
Collaborator

Fix multiple bugs

  1. Sometimes TraceGraph does not follow heap ordering.
  2. When @Bundle(trainable=True) is applied to a class method, different class instances will unintentionally share the same parameter.
  3. When calling @Bundle class method(s) multiple times of a class instance, duplicated nodes of the class instance are created, which all point to the same class instance.
  4. When accessing the bundled method of a class instance, it returns a partial function instead of FunModule, which makes accessing properties of the bundled method difficult.

Fix multiple bugs

1. Sometimes TraceGraph does not follow heap ordering.
2. When @Bundle(trainable=True) is applied to a class method, different class instances will unintentionally share the same parameter.
3. When calling @Bundle class method(s) multiple times of a class instance, duplicated nodes of the class instance are created, which all point to the same class instance.
4. When accessing the bundled method of a class instance, it returns a partial function instead of FunModule, which makes accessing properties of the bundled method difficult.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

opto/trace/bundle.py:521

  • Ensure that fun is correctly set before this assertion to avoid potential issues if fun is None or not correctly assigned.
assert fun is not self

@chinganc chinganc added the bug Something isn't working label Jan 21, 2025
Copy link
Collaborator

@allenanie allenanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allenanie allenanie merged commit 41a62c9 into main Jan 30, 2025
4 checks passed
@chinganc chinganc deleted the 0.1.3.4 branch February 20, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants