Clean up JSON #2318
Clean up JSON #2318
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
saschanaz
left a comment
saschanaz
left a comment
There was a problem hiding this comment.
I need some time to figure this out...
| } | ||
| } | ||
| }, | ||
| "dictionaries": { |
| }, | ||
| "typedefs": { | ||
| "typedef": [ | ||
| "ArrayBufferView" |
There was a problem hiding this comment.
But why is this okay?
ArrayBufferView is referenced by BufferSource that we use, so technically this is needed. But somehow we have been using it after removing it...
That's done by #405 by me 7 years ago, I need to recall what I was thinking about.
There was a problem hiding this comment.
Ahhhh because arrayBufferViewTypes has ABV so it's okay even if it's not in IDL provided types. But then why is it okay to not remove it? Hmmmmm.
There was a problem hiding this comment.
Huh because followTypeReferences explicitly ignores anything covered by baseTypeConversionMap, so even if we have ABV we ignore it because it's part of base types.
saschanaz
left a comment
saschanaz
left a comment
There was a problem hiding this comment.
I need some time to figure this out...
| }, | ||
| "typedefs": { | ||
| "typedef": [ | ||
| "ArrayBufferView" |
There was a problem hiding this comment.
Ahhhh because arrayBufferViewTypes has ABV so it's okay even if it's not in IDL provided types. But then why is it okay to not remove it? Hmmmmm.
|
Interesting, LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
2 participants
No description provided.