Skip to content

Conversation

@adr1-jpg
Copy link
Contributor

  • Removed "@fluentui/react-icons" as a dependency. It is only being used by the storybook components, not the package itself. This is to ensure that there are no issues/errors locally if there is a mismatch between the versions.

  • Added @mhdahman as package owner for azure-theme

@adr1-jpg adr1-jpg added dependencies Pull requests that update a dependency file azure-theme labels Mar 20, 2025
@adr1-jpg adr1-jpg requested a review from mainframev March 20, 2025 19:07
@adr1-jpg adr1-jpg requested review from a team as code owners March 20, 2025 19:07
@adr1-jpg adr1-jpg self-assigned this Mar 26, 2025
mainframev
mainframev previously approved these changes Mar 27, 2025
@Hotell
Copy link
Contributor

Hotell commented Mar 31, 2025

@adr1-jpg we have now tooling in place that would mitigate these kind of dependency misaligments

once fixed we can merge. ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-theme dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants