Skip to content

Conversation

@GeoffCoxMSFT
Copy link
Member

No description provided.

@GeoffCoxMSFT GeoffCoxMSFT requested a review from Hotell February 14, 2024 17:47
@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Feb 14, 2024
@GeoffCoxMSFT GeoffCoxMSFT requested a review from a team February 14, 2024 17:47
@github-actions github-actions bot added the Type: RFC Request for Feedback label Feb 14, 2024
@GeoffCoxMSFT GeoffCoxMSFT requested review from a team and removed request for a team February 14, 2024 17:47
@fabricteam
Copy link
Collaborator

fabricteam commented Feb 14, 2024

📊 Bundle size report

✅ No changes found

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.


#### Retire v7

We should announce an end-of-life to v7. Proposed: June 30th, 2024. We would lock the branch from any changes, disable and archive any build pipelines, and replace public documentation sites with a redirect to a notice that v7 is retired.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏 👏


Branch renames make it possible to have an easier current verson change if we do next version development it its own branch. We can rename master to vX and then rename next to master.

Note: We should also consider renaming master to main.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏 👏

Comment on lines 77 to 78
7. Update v0, v8 builds to publish only v0, v8 components
8. Update v9 build to publish only v9 components
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is bit confusing as it's already setup like this. can we be more specific ?


#### Separate v0, v8 and v9 branches

v7 is already in its own branch. v0, v8, and v9 are in the master branch which causes some confusion for developers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

causes some confusion for developers

It would be good to get more context/feedback on this topic.

we have self explanatory crossroad as the first thing within our Readme.md (northstar is missing there 🌙 )
image

3. Remove all v9 code from the northstar-v0, and v8 branches
4. Remove all v0 and v8 code from the master branch
5. Update v8 components to take npm dependencies on compat components
6. Update any migration components to take npm dependencies on v8 components
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we be more specific here ?

for consistency and common nomenclature I'd suggest to always provide what Set of project tags are we talking about.

for example:

I assume by "migration" components you are reffering to react-migration-v0-v9 and react-migration-v8-v9 packages. Those contain following tags (within project.json)

  • v0-v9 "tags": ["vNext", "react-northstar", "platform:web"]
  • v8-v9 "tags": ["vNext", "v8", "platform:web"]

based on that we can say:

migration components (tag:vNext,react-northstar && vNext,v8)

2. Create a northstar-v0 branch from master
3. Remove all v9 code from the northstar-v0, and v8 branches
4. Remove all v0 and v8 code from the master branch
5. Update v8 components to take npm dependencies on compat components
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compat is bit ambiguous. can we be more specific ?

I assume you mean react-portal-compat and react-portal-compat-context ?


Branch renames make it possible to have an easier current verson change if we do next version development it its own branch. We can rename master to vX and then rename next to master.

Note: We should also consider renaming master to main.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels bit out of topic for this initiative/adding more churn as well

- In progress Nav, SwatchPicker, PeoplePicker, Carousel,
- Not started: Calendar, ColorPickerCompat,
- On hold: Coachmark
- Unknown: Chart, Keytips, MarqueeSelection, ActivityItem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, supporting charts on v9 is in planning and POC right now.

GeoffCoxMSFT and others added 2 commits February 26, 2024 09:36
Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
@mltejera
Copy link
Contributor

This is great Geoff!

The idea of slimming down the active working branch is super exciting and would help me and my partners move faster.

I think we should consider defining our cadence for upgrades. How can we help partners plan for future breaking changes? (that should be MUCH smaller than v8->v9) How long do we mark API's as deprecated before removing them?


#### Sunset v8

After retiring v7, announce v8 is in sunset mode. Only critical bugs will be fixed. We will no longer be moving React forward in v8. Set a retirement date for one year out.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'maintenance mode'?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems there are a couple uses of 'maintenance' and 'sunset' in this doc. Might be good to align terminology to avoid confusion.

@GeoffCoxMSFT GeoffCoxMSFT marked this pull request as ready for review March 1, 2024 18:49
@GeoffCoxMSFT GeoffCoxMSFT requested review from a team as code owners March 1, 2024 18:49
@GeoffCoxMSFT GeoffCoxMSFT enabled auto-merge (squash) April 22, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: RFC Request for Feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants