-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Long-term support RFC #30552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Long-term support RFC #30552
Conversation
📊 Bundle size report✅ No changes found |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
|
||
| #### Retire v7 | ||
|
|
||
| We should announce an end-of-life to v7. Proposed: June 30th, 2024. We would lock the branch from any changes, disable and archive any build pipelines, and replace public documentation sites with a redirect to a notice that v7 is retired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏 👏 👏
|
|
||
| Branch renames make it possible to have an easier current verson change if we do next version development it its own branch. We can rename master to vX and then rename next to master. | ||
|
|
||
| Note: We should also consider renaming master to main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏 👏 👏
| 7. Update v0, v8 builds to publish only v0, v8 components | ||
| 8. Update v9 build to publish only v9 components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is bit confusing as it's already setup like this. can we be more specific ?
|
|
||
| #### Separate v0, v8 and v9 branches | ||
|
|
||
| v7 is already in its own branch. v0, v8, and v9 are in the master branch which causes some confusion for developers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 3. Remove all v9 code from the northstar-v0, and v8 branches | ||
| 4. Remove all v0 and v8 code from the master branch | ||
| 5. Update v8 components to take npm dependencies on compat components | ||
| 6. Update any migration components to take npm dependencies on v8 components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we be more specific here ?
for consistency and common nomenclature I'd suggest to always provide what Set of project tags are we talking about.
for example:
I assume by "migration" components you are reffering to react-migration-v0-v9 and react-migration-v8-v9 packages. Those contain following tags (within project.json)
- v0-v9
"tags": ["vNext", "react-northstar", "platform:web"] - v8-v9
"tags": ["vNext", "v8", "platform:web"]
based on that we can say:
migration components (tag:vNext,react-northstar && vNext,v8)
| 2. Create a northstar-v0 branch from master | ||
| 3. Remove all v9 code from the northstar-v0, and v8 branches | ||
| 4. Remove all v0 and v8 code from the master branch | ||
| 5. Update v8 components to take npm dependencies on compat components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compat is bit ambiguous. can we be more specific ?
I assume you mean react-portal-compat and react-portal-compat-context ?
|
|
||
| Branch renames make it possible to have an easier current verson change if we do next version development it its own branch. We can rename master to vX and then rename next to master. | ||
|
|
||
| Note: We should also consider renaming master to main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels bit out of topic for this initiative/adding more churn as well
| - In progress Nav, SwatchPicker, PeoplePicker, Carousel, | ||
| - Not started: Calendar, ColorPickerCompat, | ||
| - On hold: Coachmark | ||
| - Unknown: Chart, Keytips, MarqueeSelection, ActivityItem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, supporting charts on v9 is in planning and POC right now.
Co-authored-by: Martin Hochel <hochelmartin@gmail.com> Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
|
This is great Geoff! The idea of slimming down the active working branch is super exciting and would help me and my partners move faster. I think we should consider defining our cadence for upgrades. How can we help partners plan for future breaking changes? (that should be MUCH smaller than v8->v9) How long do we mark API's as deprecated before removing them? |
|
|
||
| #### Sunset v8 | ||
|
|
||
| After retiring v7, announce v8 is in sunset mode. Only critical bugs will be fixed. We will no longer be moving React forward in v8. Set a retirement date for one year out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'maintenance mode'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems there are a couple uses of 'maintenance' and 'sunset' in this doc. Might be good to align terminology to avoid confusion.

No description provided.