Skip to content

test storywright steps #33758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ling1726 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

test storywright steps #33758

ling1726 wants to merge 1 commit into from

Conversation

@ling1726
Copy link
Contributor

@ling1726 ling1726 commented Feb 3, 2025

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@github-actions
Copy link

github-actions bot commented Feb 3, 2025

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-breadcrumb
@fluentui/react-breadcrumb - package		 114.317 kB
31.702 kB		 114.349 kB
31.716 kB		 32 B
14 B
react-button
Button		 37.2 kB
10.811 kB		 37.232 kB
10.824 kB		 32 B
13 B
react-button
CompoundButton		 43.614 kB
12.109 kB		 43.646 kB
12.123 kB		 32 B
14 B
react-button
MenuButton		 42.015 kB
12.152 kB		 42.047 kB
12.165 kB		 32 B
13 B
react-button
SplitButton		 50.08 kB
13.724 kB		 50.112 kB
13.737 kB		 32 B
13 B
react-button
ToggleButton		 53.133 kB
12.569 kB		 53.165 kB
12.583 kB		 32 B
14 B
react-components
react-components: Button, FluentProvider & webLightTheme		 69.236 kB
20.182 kB		 69.268 kB
20.197 kB		 32 B
15 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 224.18 kB
64.859 kB		 224.212 kB
64.872 kB		 32 B
13 B
react-components
react-components: entire library		 1.17 MB
292.988 kB		 1.17 MB
293.008 kB		 32 B
20 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-card
Card - All		 101.796 kB
28.779 kB
react-card
Card		 94.57 kB
26.957 kB
react-card
CardFooter		 14.381 kB
5.799 kB
react-card
CardHeader		 16.914 kB
6.677 kB
react-card
CardPreview		 14.446 kB
5.929 kB
react-components
react-components: FluentProvider & webLightTheme		 44.473 kB
14.597 kB
react-dialog
Dialog (including children components)		 100.513 kB
30.131 kB
react-message-bar
MessageBar (all components)		 24.851 kB
9.276 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-tag-picker
@fluentui/react-tag-picker - package		 185.663 kB
55.782 kB
react-teaching-popover
TeachingPopover		 91.711 kB
27.921 kB
react-timepicker-compat
TimePicker		 108.551 kB
36.094 kB
react-tree
FlatTree		 147.793 kB
42.393 kB
react-tree
PersonaFlatTree		 148.538 kB
42.536 kB
react-tree
PersonaTree		 144.749 kB
41.391 kB
react-tree
Tree		 144.01 kB
41.265 kB
🤖 This report was generated against 3b1ac4ae0059a6c4b789fa8ead0459a1a0794d02

fabricteam
fabricteam reviewed Feb 3, 2025
View reviewed changes
apps/vr-tests-react-components/.storybook/main.js

const { registerTsPaths, registerRules, rules, loadWorkspaceAddon } = require('@fluentui/scripts-storybook');
const tsConfigPath = path.resolve(__dirname, '../../../tsconfig.base.json');

Copy link
Collaborator

@fabricteam fabricteam Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Button Converged 43 screenshots
Image Name Diff(in Pixels) Image Type
Button Converged.Disabled High Contrast.chromium.png 935 Changed
Button Converged.As an anchor.chromium.png 1925 Changed
Button Converged.Circular And Icon Only RTL.chromium.png 444 Changed
Button Converged.Outline Disabled Dark Mode.chromium.png 380 Changed
Button Converged.Circular and icon only.chromium.png 444 Changed
Button Converged.Disabled Dark Mode.chromium.png 606 Changed
Button Converged.Disabled.chromium.png 1764 Changed
Button Converged.Default High Contrast.chromium.png 935 Changed
Button Converged.Circular.chromium.png 1790 Changed
Button Converged.Default RTL.chromium.png 1925 Changed
Button Converged.Outline Disabled.chromium.png 1925 Changed
Button Converged.Primary Dark Mode.chromium.png 31 Changed
Button Converged.Default.chromium.png 1925 Changed
Button Converged.Icon only.chromium.png 579 Changed
Button Converged.Outline.chromium.png 1925 Changed
Button Converged.Outline Disabled High Contrast.chromium.png 935 Changed
Button Converged.Default Dark Mode.chromium.png 380 Changed
Button Converged.Primary Disabled Dark Mode.chromium.png 664 Changed
Button Converged.Primary Disabled High Contrast.chromium.png 1024 Changed
Button Converged.Primary Disabled.chromium.png 1933 Changed
Button Converged.Subtle Dark Mode.chromium.png 416 Changed
Button Converged.Primary.chromium.png 156 Changed
Button Converged.Primary High Contrast.chromium.png 2402 Changed
Button Converged.Size large - with long text wrapping.chromium.png 14072 Changed
Button Converged.Size large.chromium.png 3696 Changed
Button Converged.Size small - with long text wrapping.chromium.png 5996 Changed
Button Converged.Size small.chromium.png 1419 Changed
Button Converged.Size medium - with long text wrapping.chromium.png 8574 Changed
Button Converged.Subtle Disabled.chromium.png 2111 Changed
Button Converged.Subtle Disabled Dark Mode.chromium.png 416 Changed
Button Converged.Subtle.chromium.png 2111 Changed
Button Converged.Subtle High Contrast.chromium.png 1024 Changed
Button Converged.Subtle Disabled High Contrast.chromium.png 1024 Changed
Button Converged.Transparent Dark Mode.chromium.png 416 Changed
Button Converged.Transparent Disabled Dark Mode.chromium.png 416 Changed
Button Converged.Transparent.chromium.png 2111 Changed
Button Converged.Transparent Disabled High Contrast.chromium.png 1024 Changed
Button Converged.Transparent High Contrast.chromium.png 1024 Changed
Button Converged.Transparent Disabled.chromium.png 2111 Changed
Button Converged.With Icon Before Content RTL.chromium.png 2425 Changed
Button Converged.With icon before content.chromium.png 2425 Changed
Button Converged.With icon after content.chromium.png 2425 Changed
Button Converged.With Icon After Content RTL.chromium.png 2425 Changed
CompoundButton Converged 24 screenshots
Image Name Diff(in Pixels) Image Type
CompoundButton Converged.Circular And Icon Only RTL.chromium.png 1260 Changed
CompoundButton Converged.Disabled.chromium.png 6415 Changed
CompoundButton Converged.Default.chromium.png 7003 Changed
CompoundButton Converged.Default RTL.chromium.png 7003 Changed
CompoundButton Converged.Circular.chromium.png 6424 Changed
CompoundButton Converged.Circular and icon only.chromium.png 1260 Changed
CompoundButton Converged.Outline Disabled.chromium.png 7003 Changed
CompoundButton Converged.Primary Disabled.chromium.png 6716 Changed
CompoundButton Converged.Icon only.chromium.png 1633 Changed
CompoundButton Converged.Primary.chromium.png 542 Changed
CompoundButton Converged.Outline.chromium.png 7003 Changed
CompoundButton Converged.Size large - with long text wrapping.chromium.png 20998 Changed
CompoundButton Converged.Transparent Disabled.chromium.png 7331 Changed
CompoundButton Converged.With Icon After Content RTL.chromium.png 10334 Changed
CompoundButton Converged.Size large.chromium.png 13238 Changed
CompoundButton Converged.Size small - with long text wrapping.chromium.png 12411 Changed
CompoundButton Converged.Size medium - with long text wrapping.chromium.png 18282 Changed
CompoundButton Converged.Subtle Disabled.chromium.png 7331 Changed
CompoundButton Converged.Transparent.chromium.png 7331 Changed
CompoundButton Converged.Size small.chromium.png 8197 Changed
CompoundButton Converged.With Icon Before Content RTL.chromium.png 10334 Changed
CompoundButton Converged.Subtle.chromium.png 7331 Changed
CompoundButton Converged.With icon after content.chromium.png 10334 Changed
CompoundButton Converged.With icon before content.chromium.png 10334 Changed
MenuButton Converged 20 screenshots
Image Name Diff(in Pixels) Image Type
MenuButton Converged.Circular and icon only.chromium.png 444 Changed
MenuButton Converged.Circular.chromium.png 2122 Changed
MenuButton Converged.Default RTL.chromium.png 2257 Changed
MenuButton Converged.Default.chromium.png 2256 Changed
MenuButton Converged.Outline Disabled.chromium.png 2256 Changed
MenuButton Converged.Icon only.chromium.png 579 Changed
MenuButton Converged.Outline.chromium.png 2256 Changed
MenuButton Converged.Primary Disabled.chromium.png 2257 Changed
MenuButton Converged.Disabled.chromium.png 2067 Changed
MenuButton Converged.Primary.chromium.png 182 Changed
MenuButton Converged.Size large.chromium.png 4219 Changed
MenuButton Converged.Size medium - with long text wrapping.chromium.png 8570 Changed
MenuButton Converged.Size large - with long text wrapping.chromium.png 14065 Changed
MenuButton Converged.Size small.chromium.png 1661 Changed
MenuButton Converged.Size small - with long text wrapping.chromium.png 5993 Changed
MenuButton Converged.Subtle Disabled.chromium.png 2464 Changed
MenuButton Converged.Transparent Disabled.chromium.png 2464 Changed
MenuButton Converged.Subtle.chromium.png 2464 Changed
MenuButton Converged.Transparent.chromium.png 2464 Changed
MenuButton Converged.With icon.chromium.png 2756 Changed
SplitButton Converged 44 screenshots
Image Name Diff(in Pixels) Image Type
SplitButton Converged.Default High Contrast.chromium.png 1139 Changed
SplitButton Converged.Circular And Icon Only RTL.chromium.png 922 Changed
SplitButton Converged.Circular and icon only.chromium.png 923 Changed
SplitButton Converged.Default Dark Mode.chromium.png 474 Changed
SplitButton Converged.Default RTL.chromium.png 2403 Changed
SplitButton Converged.Disabled.chromium.png 2202 Changed
SplitButton Converged.Circular.chromium.png 2269 Changed
SplitButton Converged.Default.chromium.png 2403 Changed
SplitButton Converged.Disabled Dark Mode.chromium.png 756 Changed
SplitButton Converged.Disabled High Contrast.chromium.png 1139 Changed
SplitButton Converged.Icon only.chromium.png 1057 Changed
SplitButton Converged.Outline Disabled Dark Mode.chromium.png 474 Changed
SplitButton Converged.Outline Disabled High Contrast.chromium.png 1139 Changed
SplitButton Converged.Outline Disabled.chromium.png 2403 Changed
SplitButton Converged.Outline.chromium.png 2403 Changed
SplitButton Converged.Primary Dark Mode.chromium.png 39 Changed
SplitButton Converged.Primary Disabled Dark Mode.chromium.png 825 Changed
SplitButton Converged.Primary Disabled High Contrast.chromium.png 1242 Changed
SplitButton Converged.Primary Disabled.chromium.png 2401 Changed
SplitButton Converged.Primary High Contrast.chromium.png 2913 Changed
SplitButton Converged.Primary.chromium.png 194 Changed
SplitButton Converged.Size medium - with long text wrapping.chromium.png 12405 Changed
SplitButton Converged.Size large.chromium.png 4485 Changed
SplitButton Converged.Rounded.chromium.png 2403 Changed
SplitButton Converged.Size large - with long text wrapping.chromium.png 14009 Changed
SplitButton Converged.Size small - with long text wrapping.chromium.png 5970 Changed
SplitButton Converged.Size small.chromium.png 1768 Changed
SplitButton Converged.Square.chromium.png 2408 Changed
SplitButton Converged.Subtle Disabled Dark Mode.chromium.png 517 Changed
SplitButton Converged.Subtle Dark Mode.chromium.png 521 Changed
SplitButton Converged.Subtle Disabled High Contrast.chromium.png 1242 Changed
SplitButton Converged.Subtle Disabled.chromium.png 2621 Changed
SplitButton Converged.Subtle High Contrast.chromium.png 1251 Changed
SplitButton Converged.Subtle.chromium.png 2643 Changed
SplitButton Converged.With Icon After Content RTL.chromium.png 2903 Changed
SplitButton Converged.With Icon Before Content RTL.chromium.png 2903 Changed
SplitButton Converged.Transparent Dark Mode.chromium.png 521 Changed
SplitButton Converged.Transparent.chromium.png 2643 Changed
SplitButton Converged.Transparent Disabled High Contrast.chromium.png 1242 Changed
SplitButton Converged.Transparent Disabled.chromium.png 2621 Changed
SplitButton Converged.Transparent High Contrast.chromium.png 1251 Changed
SplitButton Converged.Transparent Disabled Dark Mode.chromium.png 517 Changed
SplitButton Converged.With icon after content.chromium.png 2903 Changed
SplitButton Converged.With icon before content.chromium.png 2903 Changed
ToggleButton Converged 28 screenshots
Image Name Diff(in Pixels) Image Type
ToggleButton Converged.Circular.chromium.png 1790 Changed
ToggleButton Converged.Circular and icon only.chromium.png 444 Changed
ToggleButton Converged.Checked.chromium.png 1710 Changed
ToggleButton Converged.Default High Contrast.chromium.png 935 Changed
ToggleButton Converged.Default.chromium.png 1925 Changed
ToggleButton Converged.Default Dark Mode.chromium.png 380 Changed
ToggleButton Converged.Primary.chromium.png 156 Changed
ToggleButton Converged.Default RTL.chromium.png 1925 Changed
ToggleButton Converged.Primary High Contrast.chromium.png 2402 Changed
ToggleButton Converged.Icon only.chromium.png 579 Changed
ToggleButton Converged.Primary Checked.chromium.png 76 Changed
ToggleButton Converged.Disabled.chromium.png 1764 Changed
ToggleButton Converged.Primary Dark Mode.chromium.png 31 Changed
ToggleButton Converged.Primary Disabled.chromium.png 1933 Changed
ToggleButton Converged.Outline.chromium.png 1925 Changed
ToggleButton Converged.Size large - with long text wrapping.chromium.png 14072 Changed
ToggleButton Converged.Size large.chromium.png 3696 Changed
ToggleButton Converged.Size medium - with long text wrapping.chromium.png 8574 Changed
ToggleButton Converged.Size small - with long text wrapping.chromium.png 5996 Changed
ToggleButton Converged.Size small.chromium.png 1419 Changed
ToggleButton Converged.Subtle.chromium.png 2111 Changed
ToggleButton Converged.Subtle Checked.chromium.png 1874 Changed
ToggleButton Converged.Transparent Disabled.chromium.png 2111 Changed
ToggleButton Converged.Subtle Disabled.chromium.png 2111 Changed
ToggleButton Converged.With icon after content.chromium.png 2425 Changed
ToggleButton Converged.Transparent Checked.chromium.png 2111 Changed
ToggleButton Converged.Transparent.chromium.png 2111 Changed
ToggleButton Converged.With icon before content.chromium.png 2425 Changed

@github-actions
Copy link

github-actions bot commented Feb 3, 2025

Pull request demo site: URL

@ling1726 ling1726 mentioned this pull request Feb 3, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

@marcosmoura marcosmoura Awaiting requested review from marcosmoura marcosmoura will be requested when the pull request is marked ready for review marcosmoura is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

February Project Cycle Q1 2025

Development

Successfully merging this pull request may close these issues.

2 participants

@ling1726 @fabricteam