feat(storybook): implement argTypeEnhancers for improved Slot API docs rendering #33838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
📊 Bundle size report✅ No changes found |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
|
Pull request demo site: URL |
fabricteam
reviewed
Feb 13, 2025
Hotell
changed the title
Hotell
commented
Feb 14, 2025
Hotell
commented
Feb 14, 2025
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
Hotell
commented
Feb 14, 2025
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@carlamntn please see comments and Task to follow-up/finish this PR ty |
Hotell
commented
Feb 19, 2025
Hotell
commented
Feb 19, 2025
Hotell
commented
Feb 27, 2025
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
Hotell
commented
Feb 27, 2025
github-actions
bot
modified the milestones:
February Project Cycle Q1 2025,
March Project Cycle Q1 2025
Hotell
commented
Mar 11, 2025
Contributor
Author
Hotell
left a comment
Hotell
left a comment
There was a problem hiding this comment.
added review @carlamntn
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
Hotell
commented
Mar 14, 2025
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
it seems it doesn't work properly in some scenarios (might be related to the clone ? ) avatar 
accordion is broken completely when story contains sub-component stories, it doesn't work 
|
github-actions
bot
modified the milestones:
March Project Cycle Q1 2025,
April Project Cycle Q2 2025
Hotell
commented
Apr 9, 2025
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
apps/public-docsite-v9/src/DocsComponents/FluentDocsPage.stories.tsx
Outdated
Show resolved
Hide resolved
tudorpopams
approved these changes
Apr 10, 2025
marcosmoura
pushed a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 10, 2025
…s rendering (microsoft#33838) Co-authored-by: Carla Muntean <carla.muntean@microsoft.com>
mainframev
pushed a commit
to mainframev/fluentui
that referenced
this pull request
Jun 9, 2025
…s rendering (microsoft#33838) Co-authored-by: Carla Muntean <carla.muntean@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Leverages Storybook Arg enhancer hook to tweak ouput as needed without any changes necessary in v9 codebase ( not affecting consumers of v9 )
Related Issue(s)
Slot<T>type #27105, [Bug]: display issues for slot props in Storybook #27908