chore: single state for menu and combobox #34000
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request demo site: URL |
fabricteam
reviewed
Mar 16, 2025
| @@ -0,0 +1,59 @@ | |||
| import * as React from 'react'; | |||
Collaborator
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Charts-Legend 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Charts-Legend.Overflow - RTL.expanded.chromium.png | 232 | Changed |
| Charts-Legend.Overflow - Dark Mode.expanded.chromium.png | 195 | Changed |
| Charts-Legend.Overflow.expanded.chromium.png | 232 | Changed |
Combobox Converged 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Combobox Converged.Disabled option.default.chromium.png | 56 | Changed |
| Combobox Converged.Disabled option.active option.chromium.png | 56 | Changed |
| Combobox Converged.With multiselect selection.default.chromium.png | 12 | Changed |
| Combobox Converged.With multiselect selection.hover.chromium.png | 12 | Changed |
| Combobox Converged.Disabled option.hover.chromium.png | 56 | Changed |
| Combobox Converged.With multiselect selection.active option.chromium.png | 12 | Changed |
Menu 5 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Menu.Nested Submenus Small Viewport Stacked.nested menu.chromium.png | 684 | Changed |
| Menu.Nested Submenus Small Viewport Flipped.default.chromium.png | 645 | Changed |
| Menu.Nested Submenus Small Viewport Flipped.nested menu.chromium.png | 684 | Changed |
| Menu.Scrollable Menu Small Viewport.default.chromium.png | 259 | Changed |
| Menu.Nested Submenus Small Viewport Stacked.default.chromium.png | 645 | Changed |
Menu Converged - MenuItemLinks 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Menu Converged - MenuItemLinks.default.chromium.png | 645 | Changed |
| Menu Converged - MenuItemLinks.default.hover menuitemlink.chromium.png | 657 | Changed |
Menu Converged - basic 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Menu Converged - basic.default.hover menuitem.chromium.png | 657 | Changed |
| Menu Converged - basic.default - RTL.chromium.png | 646 | Changed |
| Menu Converged - basic.default.chromium.png | 645 | Changed |
| Menu Converged - basic.default - RTL.hover menuitem.chromium.png | 657 | Changed |
Menu Converged - groups 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Menu Converged - groups.default - RTL.chromium.png | 646 | Changed |
| Menu Converged - groups.default.chromium.png | 645 | Changed |
| Menu Converged - groups.default - High Contrast.chromium.png | 442 | Changed |
| Menu Converged - groups.default - Dark Mode.chromium.png | 542 | Changed |
Menu Converged - icon slotted content 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Menu Converged - icon slotted content.default.chromium.png | 645 | Changed |
| Menu Converged - icon slotted content.default - RTL.chromium.png | 646 | Changed |
| Menu Converged - icon slotted content.default.hover menuitem.chromium.png | 657 | Changed |
| Menu Converged - icon slotted content.default - RTL.hover menuitem.chromium.png | 657 | Changed |
Menu Converged - long content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Menu Converged - long content.default - RTL.chromium.png | 1291 | Changed |
| Menu Converged - long content.default.chromium.png | 1291 | Changed |
Menu Converged - nested submenus 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Menu Converged - nested submenus.default - RTL.all open.chromium.png | 681 | Changed |
| Menu Converged - nested submenus.default.all open.chromium.png | 681 | Changed |
| Menu Converged - nested submenus.default - RTL.chromium.png | 646 | Changed |
| Menu Converged - nested submenus.default.chromium.png | 645 | Changed |
Menu Converged - secondary content 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Menu Converged - secondary content.default - RTL.hover menuitem.chromium.png | 657 | Changed |
| Menu Converged - secondary content.default - RTL.chromium.png | 646 | Changed |
| Menu Converged - secondary content.default.chromium.png | 645 | Changed |
| Menu Converged - secondary content.default.hover menuitem.chromium.png | 657 | Changed |
Menu Converged - selection 17 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Menu Converged - selection.checkbox - Dark Mode.chromium.png | 542 | Changed |
| Menu Converged - selection.checkbox - Dark Mode.selected.chromium.png | 570 | Changed |
| Menu Converged - selection.checkbox - High Contrast.chromium.png | 442 | Changed |
| Menu Converged - selection.checkbox - High Contrast.selected.chromium.png | 585 | Changed |
| Menu Converged - selection.checkbox - RTL.chromium.png | 646 | Changed |
| Menu Converged - selection.checkbox.selected.chromium.png | 659 | Changed |
| Menu Converged - selection.checkbox - RTL.selected.chromium.png | 660 | Changed |
| Menu Converged - selection.checkbox.chromium.png | 645 | Changed |
| Menu Converged - selection.switch - High Contrast.chromium.png | 544 | Changed |
| Menu Converged - selection.switch - Dark Mode.selected.chromium.png | 690 | Changed |
| Menu Converged - selection.selectable with long text.chromium.png | 1291 | Changed |
| Menu Converged - selection.switch - High Contrast.selected.chromium.png | 823 | Changed |
| Menu Converged - selection.switch - Dark Mode.chromium.png | 642 | Changed |
| Menu Converged - selection.switch.chromium.png | 765 | Changed |
| Menu Converged - selection.switch - RTL.chromium.png | 765 | Changed |
| Menu Converged - selection.switch - RTL.selected.chromium.png | 792 | Changed |
| Menu Converged - selection.switch.selected.chromium.png | 792 | Changed |
Menu Converged - selection groups 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Menu Converged - selection groups.default - RTL.selected.chromium.png | 660 | Changed |
| Menu Converged - selection groups.default.selected.chromium.png | 659 | Changed |
| Menu Converged - selection groups.default - RTL.chromium.png | 646 | Changed |
| Menu Converged - selection groups.default.chromium.png | 645 | Changed |
Menu Converged - split item 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Menu Converged - split item.default.chromium.png | 645 | Changed |
| Menu Converged - split item.default - RTL.chromium.png | 646 | Changed |
| Menu Converged - split item.default - RTL.submenu open.chromium.png | 654 | Changed |
| Menu Converged - split item.default.submenu open.chromium.png | 654 | Changed |
Menu Converged - submenuIndicator slotted content 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 669 | Changed |
| Menu Converged - submenuIndicator slotted content.default - RTL.chromium.png | 646 | Changed |
| Menu Converged - submenuIndicator slotted content.default.chromium.png | 645 | Changed |
| Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 669 | Changed |
Menu Multiline items 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Menu Multiline items.default - RTL.chromium.png | 1291 | Changed |
| Menu Multiline items.default.hover menuitem.chromium.png | 1342 | Changed |
| Menu Multiline items.default.chromium.png | 1291 | Changed |
| Menu Multiline items.default - RTL.hover menuitem.chromium.png | 1342 | Changed |
Menu nested within a MenuTrigger 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Menu nested within a MenuTrigger.default.chromium.png | 645 | Changed |
| Menu nested within a MenuTrigger.default.submenu open.chromium.png | 683 | Changed |
Shadow DOM 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Shadow DOM.Portal.normal.chromium.png | 645 | Changed |
TagPicker 7 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| TagPicker.default open - Dark Mode.chromium.png | 1371 | Changed |
| TagPicker.default open - Dark Mode.default open option mouse down.chromium.png | 2061 | Changed |
| TagPicker.grouped - Dark Mode.default.chromium.png | 1371 | Changed |
| TagPicker.default open - RTL.default open option mouse down.chromium.png | 1439 | Changed |
| TagPicker.default open - High Contrast.chromium.png | 12194 | Changed |
| TagPicker.default open.default open option mouse down.chromium.png | 1439 | Changed |
| TagPicker.grouped - High Contrast.default.chromium.png | 12194 | Changed |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,78 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png | 6 | Changed |
vr-tests-react-components/Charts-Legend 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-Legend.Overflow.expanded.chromium.png | 238 | Changed |
vr-tests-react-components/Combobox Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Combobox Converged.Disabled option.active option.chromium.png | 57 | Changed |
| vr-tests-react-components/Combobox Converged.With multiselect selection.default.chromium.png | 12 | Changed |
vr-tests-react-components/Menu 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu.Nested Submenus Small Viewport Flipped.nested menu.chromium.png | 671 | Changed |
| vr-tests-react-components/Menu.Nested Submenus Small Viewport Stacked.default.chromium.png | 645 | Changed |
| vr-tests-react-components/Menu.Nested Submenus Small Viewport Stacked.nested menu.chromium.png | 670 | Changed |
| vr-tests-react-components/Menu.Scrollable Menu Small Viewport.default.chromium.png | 259 | Changed |
vr-tests-react-components/Menu Converged - icon slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - icon slotted content.default - RTL.hover menuitem.chromium.png | 658 | Changed |
| vr-tests-react-components/Menu Converged - icon slotted content.default.hover menuitem.chromium.png | 657 | Changed |
vr-tests-react-components/Menu Converged - nested submenus 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - nested submenus.default - RTL.all open.chromium.png | 667 | Changed |
| vr-tests-react-components/Menu Converged - nested submenus.default.all open.chromium.png | 668 | Changed |
vr-tests-react-components/Menu Converged - secondary content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - secondary content.default - RTL.hover menuitem.chromium.png | 655 | Changed |
| vr-tests-react-components/Menu Converged - secondary content.default.hover menuitem.chromium.png | 654 | Changed |
vr-tests-react-components/Menu Converged - selection 9 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - selection.checkbox - Dark Mode.selected.chromium.png | 574 | Changed |
| vr-tests-react-components/Menu Converged - selection.checkbox - High Contrast.selected.chromium.png | 594 | Changed |
| vr-tests-react-components/Menu Converged - selection.checkbox - RTL.selected.chromium.png | 657 | Changed |
| vr-tests-react-components/Menu Converged - selection.selectable with long text.chromium.png | 1291 | Changed |
| vr-tests-react-components/Menu Converged - selection.checkbox.selected.chromium.png | 656 | Changed |
| vr-tests-react-components/Menu Converged - selection.switch - Dark Mode.selected.chromium.png | 713 | Changed |
| vr-tests-react-components/Menu Converged - selection.switch - High Contrast.selected.chromium.png | 846 | Changed |
| vr-tests-react-components/Menu Converged - selection.switch.chromium.png | 777 | Changed |
| vr-tests-react-components/Menu Converged - selection.switch.selected.chromium.png | 795 | Changed |
vr-tests-react-components/Menu Converged - selection groups 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - selection groups.default - RTL.selected.chromium.png | 657 | Changed |
| vr-tests-react-components/Menu Converged - selection groups.default.selected.chromium.png | 656 | Changed |
| vr-tests-react-components/Menu Converged - selection groups.default.chromium.png | 645 | Changed |
vr-tests-react-components/Menu Converged - split item 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - split item.default - RTL.submenu open.chromium.png | 654 | Changed |
| vr-tests-react-components/Menu Converged - split item.default.submenu open.chromium.png | 654 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 659 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.chromium.png | 645 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 658 | Changed |
vr-tests-react-components/Menu Multiline items 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Multiline items.default - RTL.hover menuitem.chromium.png | 1336 | Changed |
| vr-tests-react-components/Menu Multiline items.default.chromium.png | 1291 | Changed |
| vr-tests-react-components/Menu Multiline items.default.hover menuitem.chromium.png | 1337 | Changed |
vr-tests-react-components/Menu nested within a MenuTrigger 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu nested within a MenuTrigger.default.chromium.png | 645 | Changed |
| vr-tests-react-components/Menu nested within a MenuTrigger.default.submenu open.chromium.png | 668 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 857 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 601 | Changed |
vr-tests-react-components/Shadow DOM 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Shadow DOM.Portal.normal.chromium.png | 645 | Changed |
vr-tests-react-components/TagPicker 7 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.default open - Dark Mode.chromium.png | 1359 | Changed |
| vr-tests-react-components/TagPicker.default open - Dark Mode.default open option mouse down.chromium.png | 2045 | Changed |
| vr-tests-react-components/TagPicker.default open - High Contrast.chromium.png | 12226 | Changed |
| vr-tests-react-components/TagPicker.default open - RTL.default open option mouse down.chromium.png | 1435 | Changed |
| vr-tests-react-components/TagPicker.default open.default open option mouse down.chromium.png | 1437 | Changed |
| vr-tests-react-components/TagPicker.grouped - Dark Mode.default.chromium.png | 1359 | Changed |
| vr-tests-react-components/TagPicker.grouped - High Contrast.default.chromium.png | 12226 | Changed |
There were 38 duplicate changes discarded. Check the build logs for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.