-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore: update Typescript target to ES2020 for v9 #34035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: update Typescript target to ES2020 for v9 #34035
Conversation
📊 Bundle size reportUnchanged fixtures
|
|
Pull request demo site: URL |
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual regressions to review in the fluentui-web-components-v3 Visual Regression Report
Avatar 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar. - Dark Mode.normal.chromium.png | 10569 | Changed |
Badge 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Badge. - Dark Mode.normal.chromium.png | 511 | Changed |
Checkbox 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Checkbox. - Dark Mode.normal.chromium_1.png | 3 | Changed |
MenuList 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| MenuList. - RTL.2nd selected.chromium.png | 17 | Changed |
| MenuList. - RTL.normal.chromium_1.png | 39102 | Changed |
🕵 FluentUIV0 No visual regressions between this PR and main |
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
Callout 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Callout.Bottom center.default.chromium.png | 2146 | Changed |
react-charting-LineChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-LineChart.Gaps.default.chromium.png | 1 | Changed |
react-charting-VerticalBarChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png | 4 | Changed |
🕵 fluentuiv9 No visual regressions between this PR and main |
This reverts commit 558bf77.
769b57f to
250256c
Compare
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png | 6 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 491 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 725 | Changed |
vr-tests-react-components/Skeleton converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Skeleton converged.Opaque Skeleton with rectangle - Dark Mode.default.chromium.png | 2 | Changed |
vr-tests-react-components/TagPicker 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled.chromium.png | 678 | Changed |
vr-tests-web-components/Badge 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png | 444 | Changed |
vr-tests-web-components/MenuList 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/MenuList. - RTL.normal.chromium_1.png | 39082 | Changed |
vr-tests-web-components/RadioGroup 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/RadioGroup. - Dark Mode.normal.chromium_1.png | 59 | Changed |
vr-tests-web-components/Switch 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Switch. - Dark Mode.hover.chromium_2.png | 92 | Changed |
vr-tests/Callout 13 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Callout.Beak 25.default.chromium.png | 2185 | Changed |
| vr-tests/Callout.Bottom left edge.default.chromium.png | 2181 | Changed |
| vr-tests/Callout.Bottom center.default.chromium.png | 2116 | Changed |
| vr-tests/Callout.Gap space 25.default.chromium.png | 2181 | Changed |
| vr-tests/Callout.Bottom right edge - RTL.default.chromium.png | 1114 | Changed |
| vr-tests/Callout.Left bottom edge.default.chromium.png | 3123 | Changed |
| vr-tests/Callout.Left center.default.chromium.png | 2544 | Changed |
| vr-tests/Callout.Left top edge.default.chromium.png | 2168 | Changed |
| vr-tests/Callout.No beak.default.chromium.png | 2177 | Changed |
| vr-tests/Callout.Right bottom edge.default.chromium.png | 3037 | Changed |
| vr-tests/Callout.Right center.default.chromium.png | 2080 | Changed |
| vr-tests/Callout.Top right edge.default.chromium.png | 1134 | Changed |
| vr-tests/Callout.Top left edge.default.chromium.png | 2196 | Changed |
vr-tests/Keytip 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Keytip.Disabled.default.chromium.png | 24 | Changed |
vr-tests/ScrollablePane 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/ScrollablePane.Default ScrollablePane Example.scrolled.chromium.png | 8834 | Changed |
vr-tests/react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-AreaChart.Custom Accessibility.default.chromium.png | 11 | Changed |
vr-tests/react-charting-LineChart 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-LineChart.Events.default.chromium.png | 1 | Changed |
| vr-tests/react-charting-LineChart.Multiple - Dark Mode.default.chromium.png | 181 | Changed |
| vr-tests/react-charting-LineChart.Multiple - RTL.default.chromium.png | 200 | Changed |
vr-tests/react-charting-MultiStackBarChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-MultiStackBarChart.Basic_Absolute.default.chromium.png | 359 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.

Previous Behavior
New Behavior
Related Issue(s)