chore: migrate repo to React 19 #35434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
added
Package: charting
Fluent UI react-components (v9)
Fluent UI react (v8)
Hotell
commented
Oct 31, 2025
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
Hotell
commented
Nov 3, 2025
| setStartFromX(0); | ||
| } | ||
| }, [props, prevProps]); | ||
| }, [props.width, props.height, props.chartType, props.showYAxisLables, props.yAxisType]); |
Contributor
Author
There was a problem hiding this comment.
this was causing infinite loops exposed within test run - migrated to use refs and not references for hook integrity
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| jobs: | ||
| generate_vrt_screenshots: | ||
| if: ${{ github.repository_owner == 'microsoft' }} |
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 27053 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 276 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 595 | Changed |
vr-tests-react-components/TagPicker 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 659 | Changed |
| vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png | 1321 | Changed |
| vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
| vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 678 | Changed |
vr-tests-web-components/Accordion 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Accordion. - Dark Mode.normal.chromium_1.png | 3151 | Changed |
vr-tests-web-components/Checkbox 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Checkbox. - Dark Mode.normal.chromium_1.png | 29 | Changed |
| vr-tests-web-components/Checkbox.Checked.normal.chromium.png | 118 | Changed |
| vr-tests-web-components/Checkbox.Circular Checked.normal.chromium.png | 90 | Changed |
| vr-tests-web-components/Checkbox.Disabled.normal.chromium.png | 39 | Changed |
vr-tests-web-components/MenuList 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/MenuList. - Dark Mode.normal.chromium.png | 500 | Changed |
| vr-tests-web-components/MenuList. - RTL.normal.chromium_1.png | 39082 | Changed |
vr-tests-web-components/Radio 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Radio. - Dark Mode.normal.chromium_1.png | 29 | Changed |
vr-tests-web-components/RadioGroup 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/RadioGroup. - Dark Mode.normal.chromium_1.png | 59 | Changed |
| vr-tests-web-components/RadioGroup.Default Checked.normal.chromium.png | 51 | Changed |
| vr-tests-web-components/RadioGroup.Disabled Item.normal.chromium.png | 27 | Changed |
vr-tests-web-components/Switch 5 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Switch. - Dark Mode.normal.chromium_1.png | 179 | Changed |
| vr-tests-web-components/Switch.Disabled Checked.hover.chromium.png | 187 | Changed |
| vr-tests-web-components/Switch.Checked.normal.chromium.png | 201 | Changed |
| vr-tests-web-components/Switch.Disabled Checked.normal.chromium.png | 165 | Changed |
| vr-tests-web-components/Switch.Disabled.normal.chromium.png | 100 | Changed |
vr-tests/Callout 7 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Callout.Right center.default.chromium.png | 2080 | Changed |
| vr-tests/Callout.Gap space 25.default.chromium.png | 2181 | Changed |
| vr-tests/Callout.Right top edge.default.chromium.png | 1116 | Changed |
| vr-tests/Callout.No callout width specified.default.chromium.png | 2126 | Changed |
| vr-tests/Callout.Rendering callout attached to a rectangle.default.chromium.png | 1832 | Changed |
| vr-tests/Callout.Top auto edge.default.chromium.png | 2196 | Changed |
| vr-tests/Callout.Top center.default.chromium.png | 2113 | Changed |
vr-tests/Keytip 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Keytip.Offset.default.chromium.png | 86 | Changed |
vr-tests/react-charting-MultiStackBarChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-MultiStackBarChart.Basic_Absolute - RTL.default.chromium.png | 343 | Changed |
There were 15 duplicate changes discarded. Check the build logs for more information.
Hotell
force-pushed
the
r19/repo-migration
branch
from
26a1e2e to
5b187ac
Compare
Hotell
commented
Nov 4, 2025
| "outDir": "dist/esm", | ||
| "importHelpers": true | ||
| "importHelpers": true, | ||
| "types": [] |
Contributor
Author
There was a problem hiding this comment.
locally builds were failing, after investigation the cause is that all node_modules/@types were part of compilation production assets which might provide false positives - this change fixes it and aligns with how we run tsc for prod assets in repo
Hotell
commented
Nov 4, 2025
| '\\.(scss)$': path.resolve(__dirname, './v8/jest-style-mock.js'), | ||
| KeyCodes: path.resolve(__dirname, './v8/jest-mock.js'), | ||
| enzyme: path.resolve(__dirname, './v8/jest-mock.js'), | ||
| // explicitly needed as R17 doesn't have this API and if not declared explicitly our integration jest config wouldn't be able to override this |
Contributor
Author
There was a problem hiding this comment.
same override as we use for v9. to mitigate this we would need to completely drop react-hooks and provide extra transforms for RIT pipeline so React 17 passes. not a prio atm
Hotell
commented
Nov 4, 2025
| ); | ||
| }); | ||
| CartesianChart.displayName = 'CartesianChart'; | ||
| CartesianChart.defaultProps = { |
Contributor
Author
There was a problem hiding this comment.
defaultProps no longer work in React 19 https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops
Hotell
commented
Nov 4, 2025
| "esModuleInterop": true, | ||
| "isolatedModules": true | ||
| "isolatedModules": true, | ||
| "skipLibCheck": true |
Contributor
Author
There was a problem hiding this comment.
incompatible SB types with React 19, need to skip
Hotell
commented
Nov 4, 2025
| /** | ||
| * @jest-environment node | ||
| */ | ||
| import * as React from 'react'; |
Contributor
Author
There was a problem hiding this comment.
decoupled SSR jest test that were causing issues within browser mocked env (react loaded incompatible modules)
Hotell
force-pushed
the
r19/repo-migration
branch
from
21478a9 to
5c20411
Compare
Hotell
requested review from
a team,
ThomasMichon,
dzearing,
khmakoto and
spmonahan
as code owners
…ect in CartesianChart
…pting tests and jest configuration
…String, increase timeout, and fix webpack bundling errors caused by react-monaco
…inclusion to production compilation output
Hotell
force-pushed
the
r19/repo-migration
branch
from
5c20411 to
cd4097f
Compare
mainframev
approved these changes
Nov 5, 2025
dmytrokirpa
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
general:
MutableRefObjectdeprecation were muted for now / 62f1dcdcustom jsx runtime
createElementwithin tests / 72eb938storybook:
.d.tsforced using skipLibCheck for addon / 8dd92e1test(jest)
ssr
charts:
defaultPropsapi doesn't work anymore - logic was refactored to use ES6 default paramsRelated Issue(s)