fix(vr-tests-web-components): update test scripts and fix story errors #35475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrokirpa
commented
Nov 11, 2025
dmytrokirpa
commented
Nov 11, 2025
apps/vr-tests-web-components/src/stories/menu-list/menu-list.stories.tsx
Show resolved
Hide resolved
📊 Bundle size report✅ No changes found |
dmytrokirpa
commented
Nov 11, 2025
apps/vr-tests-web-components/src/stories/radio-group/radio-group.stories.tsx
Show resolved
Hide resolved
dmytrokirpa
commented
Nov 11, 2025
|
Pull request demo site: URL |
dmytrokirpa
commented
Nov 11, 2025
dmytrokirpa
commented
Nov 11, 2025
apps/vr-tests-web-components/src/stories/checkbox/checkbox-indeterminate.stories.tsx
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
3 tasks
mainframev
approved these changes
Nov 11, 2025
Contributor
Author
|
Could I get a review for this one, please, @microsoft/fui-wc? |
davatron5000
approved these changes
Nov 14, 2025
dmytrokirpa
deleted the
fix/vr-tests-web-components/bail-on-stories-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
We found in #35346 (comment) that some WebComponents VR tests were logging errors quietly without causing the pipeline to fail.
New Behavior
--bailOnStoriesErrorflag to thetest-vrscript in package.json for improved error handling.Array.fromasHTMLCollectiondoesn't haveforEachmethodidattribute to the long text link story for proper element targeting.aria-haspopupattributes.fluent-radioselectors for as there are no elements with the[role=radio]attributefluent-sliderinstead of[role="slider"]as there are no elements such elementsRelated Issue(s)
--bailOnStoriesErrorparam tovr-testsandvr-tests-web-components#35430