-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace #35611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
02929a3
feat(nx): use scripts-api-extractor package as dependency via input c…
Hotell 171f24b
chore:use nx graph instead of manually defined devDependencies in pac…
Hotell c6220c3
chore(workspace-plugin): remove generating devDeps when creating library
Hotell f296be0
chore: remove unused 3rd party deps
Hotell 3d15ce5
change files
Hotell a33772c
chore: fix yarn.lock aliases merge preventing frozen install
Hotell 6ce9950
fix: revert using jest-serializer-merge-styles as build dependency fo…
Hotell fbe4de2
ci: remove invalid --exclude proejct definition from main and rit pip…
Hotell 1ebc61f
chore(nx): revert api-extractor invalidation to physicall input glob …
Hotell 00f4180
chore(ssr-tests): fix nx graph dependency resolution
Hotell 2d8e0d8
fix(public-docsite-resource): add deep import used within ssr-test in…
Hotell 5fd1b11
fix(monorepo): accomodate nx graph resolution for devDeps for getDepe…
Hotell 66d9d4e
chore: use explicit require for jest-serializer-merge-styles instead …
Hotell 240cba7
fix(public-docsite-resource): add additional export maps that are use…
Hotell af5ca1a
style: apply formatting
Hotell d25699d
style(stories): remove not needed 'import/no-extraneous-dependencies'…
Hotell b29d417
fix(workspace-plugin): remove import/no-extraneous-dependencies rule …
Hotell 83db811
fixup! style(stories): remove not needed 'import/no-extraneous-depend…
Hotell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,20 @@ | |
| "description": "Fluent UI React local demo app", | ||
| "main": "lib-commonjs/index.js", | ||
| "module": "lib/index.js", | ||
| "exports": { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these nested path imports are used across ssr-tests and public-docsite ( v8 ), in order to be able to resovle the dep graph correctly by nx we added proper API export maps |
||
| ".": { | ||
| "types": "./lib/index.d.ts", | ||
| "import": "./lib/index.js", | ||
| "require": "./lib-commonjs/index.js" | ||
| }, | ||
| "./lib/AppDefinition": { | ||
| "types": "./lib/AppDefinition.d.ts", | ||
| "import": "./lib/AppDefinition.js", | ||
| "require": "./lib-commonjs/AppDefinition.js" | ||
| }, | ||
| "./dist/api": "./dist/api", | ||
| "./dist/api/references": "./dist/api/references" | ||
| }, | ||
| "sideEffects": [ | ||
| "*.global.*", | ||
| "*Examples.*", | ||
|
|
@@ -27,13 +41,6 @@ | |
| "start": "just-scripts dev", | ||
| "update-snapshots": "just-scripts jest -u" | ||
| }, | ||
| "devDependencies": { | ||
| "@fluentui/api-docs": "*", | ||
| "@fluentui/eslint-plugin": "*", | ||
| "@fluentui/scripts-monorepo": "*", | ||
| "@fluentui/scripts-tasks": "*", | ||
| "@fluentui/scripts-webpack": "*" | ||
| }, | ||
| "dependencies": { | ||
| "@fluentui/react": "*", | ||
| "@fluentui/react-charting": "*", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
change/@fluentui-api-docs-43426168-a744-4dca-9652-10771141c98b.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/api-docs", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-azure-themes-ed338bbb-1259-4166-b2bf-32d95ac71765.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/azure-themes", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-babel-preset-global-context-2128c934-b8cd-40ab-9ec6-63399faa6d83.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/babel-preset-global-context", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
...ge/@fluentui-babel-preset-storybook-full-source-fb636641-8df4-4995-82cd-43bd57b6448f.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/babel-preset-storybook-full-source", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-chart-utilities-e53758cf-e5e7-4ef4-8cf5-9b35c8c20d0f.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/chart-utilities", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-chart-web-components-bc34018b-eb29-44ee-8576-d6c8d509d47d.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/chart-web-components", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-codemods-a400d2a8-ba85-44d5-99a9-f60e452ce08b.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/codemods", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-common-styles-d33be1c7-d421-425d-9db7-c1f1a3385b66.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/common-styles", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-cra-template-987869d0-b57e-4838-a85c-1dcbd3cc7de0.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/cra-template", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-date-time-utilities-dbd34fd7-1d24-4caa-8ba2-f7df03bdeb86.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/date-time-utilities", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-dom-utilities-32820fbb-6ca1-4209-8601-a6773884d623.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/dom-utilities", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-example-data-d1f8e225-afbc-4d9e-9ba6-775677b909b5.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/example-data", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-fluent2-theme-31a8fa90-1cd7-4607-9f35-03fb4c8d222a.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/fluent2-theme", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-font-icons-mdl2-375751f9-38de-4204-a454-e0ab3f9198fe.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/font-icons-mdl2", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-foundation-legacy-70ccefbf-2610-4304-a997-217398aab29c.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "chore: use nx graph instead of manually defined devDependencies in package.json files across whole workspace", | ||
| "packageName": "@fluentui/foundation-legacy", | ||
| "email": "martinhochel@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.