fix(react-charts): fix chart width issue in donut chart #35652
+694
−728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Basic - Dark Mode.default.chromium.png | 9043 | Changed |
| vr-tests-react-components/Charts-DonutChart.Basic.default.chromium.png | 10058 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 5882 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 4731 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5883 | Changed |
| vr-tests-react-components/Charts-DonutChart.Basic - RTL.default.chromium.png | 10059 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 728 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 868 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled.chromium.png | 677 | Changed |
| vr-tests-react-components/TagPicker.disabled - Dark Mode.chromium.png | 658 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
Contributor
|
The chart got shifted down after your previous change. Can you fix that as well. |
Contributor
Author
can you share the run link? |
Contributor
|
AtishayMsft
reviewed
Jan 15, 2026
| className={classes.chart} | ||
| aria-label={data?.chartTitle} | ||
| width={_width} | ||
| height={_height! + titleHeight / 2} |
Contributor
Author
There was a problem hiding this comment.
adding titleHeight is increasing distance between legends and donut a lot.
to resolve above issue also (chart shifting downwards), I will transform pie by titleHeight/2, currently it is getting transformed by titleHeight which is increasing the gap
Contributor
Author
AtishayMsft
reviewed
Jan 15, 2026
| legendContainer.current = e; | ||
| }} | ||
| className={classes.legendContainer} | ||
| style={{ marginTop: data?.chartTitle ? `-${titleHeight}px` : undefined }} |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)