Skip to content

Conversation

@JocelynBerrendonner
Copy link
Member

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
  • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Builds on Windows
  • genPolicy only: Updated sample YAMLs' policy annotations, if applicable
Summary

This PR captures the PoC code for SWIFT v2 support in Kata. The code does two things:

  1. It adds support for vmbus based physical network adapters
  2. It adds support for non-VF (i.e. non SR-IOV) physical network adapters

The code mostly modifies the physical network path to provide the above support. It also uses the same approach as VETH for all the non-VF / non SR-IOV network adapters that are being added to a Kata UVM.

Associated issues
Links to CVEs
Test Methodology

Manual validation of the PoC. No regression testing (this is pure PoC code)

}

if isPhysical {
if s.config.HypervisorConfig.ColdPlugVFIO == config.NoPort {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that still be needed?

} else {
// The network namespace would have been deleted at this point
// if it has not been created by virtcontainers.
if !netNsCreated {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some logging here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants