Skip to content

If target has no outputs set, and no global outputGlob set, assume no outputs #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dobesv wants to merge 2 commits into
base: master
Choose a base branch
from
Open

If target has no outputs set, and no global outputGlob set, assume no outputs #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e0a77c
If target has no outputs set, and no global outputGlob set, assume no…
dobesv Mar 29, 2025
72f3c63
Change files
dobesv Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions change/change-50d5ec94-8c4b-470b-be07-7bebaea6503f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"type": "patch",
"comment": "If target has no outputs set, and no global outputGlob set, assume no outputs",
"packageName": "@lage-run/cache",
"email": "dobes@formative.com",
"dependentChangeType": "patch"
}
]
}
2 changes: 1 addition & 1 deletion packages/cache/src/providers/BackfillCacheProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export class BackfillCacheProvider implements CacheProvider {
const cacheStorage = this.getTargetCacheStorageProvider(target.cwd, hash);

try {
await cacheStorage.put(hash, target.outputs ?? this.options.cacheOptions.outputGlob ?? ["**/*"]);
await cacheStorage.put(hash, target.outputs ?? this.options.cacheOptions.outputGlob ?? []);
} catch (error) {
let message;

Expand Down