Sanitize hashes filenames #919
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree |
ecraig12345
reviewed
Aug 7, 2025
Member
ecraig12345
left a comment
ecraig12345
left a comment
There was a problem hiding this comment.
Thanks for the PR! Could you please add a change file by running yarn change?
| const target = createTarget(monorepo1.root, "package-a", "build:test"); | ||
| const hash = await getHash(hasher, target); | ||
|
|
||
| expect(() => hasher.writeTargetHashesManifest()).not.toThrow(); |
Member
There was a problem hiding this comment.
Maybe instead of this, you could check that the expected directory exists with the sanitized name?
Agree with this proposal Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ought to fix #918.
I tried adding a test, but maybe it could be made more precise?