-
Notifications
You must be signed in to change notification settings - Fork 342
Dangerously disable elicitation #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR renames the --insecure-disable-elicitation server startup option to --dangerously-disable-elicitation to align with the naming convention used by other security-related options (e.g., --dangerously-disable-http-incoming-auth). This is a breaking change as the old option name is no longer supported.
Key Changes
- Renamed CLI option from
--insecure-disable-elicitationto--dangerously-disable-elicitation - Updated all references across code, documentation, and tests to use the new naming convention
- Updated terminology from "INSECURE" to "DANGEROUS" in user-facing messages
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| servers/Azure.Mcp.Server/vscode/CHANGELOG.md | Updated historical changelog entry with new option name (should preserve historical accuracy) |
| servers/Azure.Mcp.Server/docs/azmcp-commands.md | Updated documentation to reflect new option name and terminology |
| servers/Azure.Mcp.Server/CHANGELOG.md | Added breaking change announcement for the rename |
| core/Microsoft.Mcp.Core/src/Commands/TelemetryConstants.cs | Updated telemetry tag name constant |
| core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/ServiceStartCommandTests.cs | Updated unit tests to use new option name |
| core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/Commands/ToolLoading/CommandFactoryToolLoaderTests.cs | Updated tool loader tests to use new option name |
| core/Azure.Mcp.Core/src/Areas/Server/Options/ServiceStartOptions.cs | Updated property name and JSON serialization name |
| core/Azure.Mcp.Core/src/Areas/Server/Options/ServiceOptionDefinitions.cs | Updated option definition constant and CLI option |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/ToolLoaderOptions.cs | Updated record parameter name |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/NamespaceToolLoader.cs | Updated option reference |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/CommandFactoryToolLoader.cs | Updated option reference |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/BaseToolLoader.cs | Updated parameter name, documentation, and warning message |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ServiceStartCommand.cs | Updated option registration and binding |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ServiceCollectionExtensions.cs | Updated service registration to use new property name |
What does this PR do?
[Provide a clear, concise description of the changes]rename insecure-disable-elicitation to dangerously-disable-elicitation
[Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline