Skip to content

Conversation

@xiangyan99
Copy link
Member

What does this PR do?

[Provide a clear, concise description of the changes]

rename insecure-disable-elicitation to dangerously-disable-elicitation

[Any additional context, screenshots, or information that helps reviewers]

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@xiangyan99 xiangyan99 marked this pull request as ready for review January 6, 2026 19:30
@xiangyan99 xiangyan99 requested review from a team as code owners January 6, 2026 19:30
Copilot AI review requested due to automatic review settings January 6, 2026 19:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the --insecure-disable-elicitation server startup option to --dangerously-disable-elicitation to align with the naming convention used by other security-related options (e.g., --dangerously-disable-http-incoming-auth). This is a breaking change as the old option name is no longer supported.

Key Changes

  • Renamed CLI option from --insecure-disable-elicitation to --dangerously-disable-elicitation
  • Updated all references across code, documentation, and tests to use the new naming convention
  • Updated terminology from "INSECURE" to "DANGEROUS" in user-facing messages

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
servers/Azure.Mcp.Server/vscode/CHANGELOG.md Updated historical changelog entry with new option name (should preserve historical accuracy)
servers/Azure.Mcp.Server/docs/azmcp-commands.md Updated documentation to reflect new option name and terminology
servers/Azure.Mcp.Server/CHANGELOG.md Added breaking change announcement for the rename
core/Microsoft.Mcp.Core/src/Commands/TelemetryConstants.cs Updated telemetry tag name constant
core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/ServiceStartCommandTests.cs Updated unit tests to use new option name
core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/Commands/ToolLoading/CommandFactoryToolLoaderTests.cs Updated tool loader tests to use new option name
core/Azure.Mcp.Core/src/Areas/Server/Options/ServiceStartOptions.cs Updated property name and JSON serialization name
core/Azure.Mcp.Core/src/Areas/Server/Options/ServiceOptionDefinitions.cs Updated option definition constant and CLI option
core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/ToolLoaderOptions.cs Updated record parameter name
core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/NamespaceToolLoader.cs Updated option reference
core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/CommandFactoryToolLoader.cs Updated option reference
core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/BaseToolLoader.cs Updated parameter name, documentation, and warning message
core/Azure.Mcp.Core/src/Areas/Server/Commands/ServiceStartCommand.cs Updated option registration and binding
core/Azure.Mcp.Core/src/Areas/Server/Commands/ServiceCollectionExtensions.cs Updated service registration to use new property name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants