-
Notifications
You must be signed in to change notification settings - Fork 342
Update server instruction to be more specific about azure services #1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update server instruction to be more specific about azure services #1474
Conversation
|
This is a minor change which doesn't need to be included in the changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Azure MCP server instruction rules to make the trigger for the bestpractices tool more specific. The change clarifies that the tool should be invoked when "generating code for any Azure services" rather than just "generating code for Azure", which should help improve the reliability of the tool being triggered during code generation prompts.
- Updates the "Use Azure Code Gen Best Practices" rule to be more explicit about Azure services
| - Only call your `bestpractices` tool when you are sure the user is discussing Azure; do not call it otherwise. | ||
| - Use Azure AI App Code Generation Best Practices: When generating code for AI applications, AI agents, workflows, | ||
| or chatbots, invoke your `get_bestpractices_ai_app` command (under `get_bestpractices` tool) if tool available. | ||
| or chatbots, invoke your `get_bestpractices_ai_app` command (under `get_azure_bestpractices` tool) if tool available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The concept of "under" may not be clear to the LLM. It can be more explicitly said as "call get_azure_bestpractices tool and follow its response to get the ai app bestpractices. I suppose the LLM can figure out the argument value get_bestpractices_ai_app to use when there is enough context from the response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The AI app bestpractices piece was added and tested by the ai toolkit team. They were satisfied with its performance. I will leave it for them to decide. @XiaofuHuang FYI about Jason's suggestion above.
What does this PR do?
I've noticed some code generation prompts sometimes didn't trigger bestpractices tool. I am making this change to specifically call out
generating code for any Azure servicesGitHub issue number?
N/A
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline