Skip to content

Conversation

@chris-oo
Copy link
Member

Two additional fixes for running cross compiled windows under WSL for vmm-tests. This now allows running something like cargo xflowey vmm-tests --target windows-x64 --dir /mnt/q/vmm_tests_out end to end, and having it build and execute all tests within WSL.

@chris-oo chris-oo requested a review from a team as a code owner January 15, 2026 22:33
Copilot AI review requested due to automatic review settings January 15, 2026 22:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issues with running cross-compiled Windows VMM tests under WSL. It enables end-to-end execution of cargo xflowey vmm-tests --target windows-x64 --dir /mnt/q/vmm_tests_out within WSL by ensuring proper environment variable propagation and path validation.

Changes:

  • Added WSLENV configuration to propagate environment variables when running Windows executables from WSL
  • Added validation to ensure Windows-accessible paths are used when targeting Windows from WSL
  • Made running_in_wsl() function public in flowey_cli for reuse across crates

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
flowey/flowey_lib_hvlite/src/run_prep_steps.rs Adds WSLENV handling to propagate environment variables when running Windows prep_steps executable from WSL
flowey/flowey_hvlite/src/pipelines/vmm_tests.rs Validates output directory is Windows-accessible when targeting Windows from WSL
flowey/flowey_cli/src/lib.rs Makes running_in_wsl() function public and adds documentation

@chris-oo chris-oo force-pushed the more-flowey-vmmtests-wsl branch 2 times, most recently from 6ff355d to c5039bd Compare January 21, 2026 22:04
@chris-oo chris-oo force-pushed the more-flowey-vmmtests-wsl branch from c5039bd to 7dcead5 Compare January 23, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants