-
Notifications
You must be signed in to change notification settings - Fork 163
flowey: fix more issues with running vmm-tests under wsl #2653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes issues with running cross-compiled Windows VMM tests under WSL. It enables end-to-end execution of cargo xflowey vmm-tests --target windows-x64 --dir /mnt/q/vmm_tests_out within WSL by ensuring proper environment variable propagation and path validation.
Changes:
- Added WSLENV configuration to propagate environment variables when running Windows executables from WSL
- Added validation to ensure Windows-accessible paths are used when targeting Windows from WSL
- Made
running_in_wsl()function public in flowey_cli for reuse across crates
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
flowey/flowey_lib_hvlite/src/run_prep_steps.rs |
Adds WSLENV handling to propagate environment variables when running Windows prep_steps executable from WSL |
flowey/flowey_hvlite/src/pipelines/vmm_tests.rs |
Validates output directory is Windows-accessible when targeting Windows from WSL |
flowey/flowey_cli/src/lib.rs |
Makes running_in_wsl() function public and adds documentation |
6ff355d to
c5039bd
Compare
c5039bd to
7dcead5
Compare
Two additional fixes for running cross compiled windows under WSL for vmm-tests. This now allows running something like
cargo xflowey vmm-tests --target windows-x64 --dir /mnt/q/vmm_tests_outend to end, and having it build and execute all tests within WSL.