Update stale SNP TODO comments #2699
Conversation
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
There was a problem hiding this comment.
Pull request overview
Removes outdated SNP-related TODOs and updates SNP RMP-adjust documentation around VMSA handling.
Changes:
- Removes a stale TODO comment in SNP CPUID extended max function logic.
- Updates
rmpadjust_pagesrustdoc with notes about how VMSA pages are converted.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| openhcl/virt_mshv_vtl/src/cvm_cpuid/snp.rs | Removes an outdated SNP TODO comment in CPUID max-leaf selection. |
| openhcl/hcl/src/ioctl/snp.rs | Updates rmpadjust_pages documentation and modifies behavior around VMSA-related RMPADJUST handling. |
| pub fn rmpadjust_pages( | ||
| &self, | ||
| range: MemoryRange, | ||
| value: SevRmpAdjust, | ||
| terminate_on_failure: bool, | ||
| ) -> Result<(), SnpPageError> { | ||
| if value.vmsa() { | ||
| // TODO SNP: VMSA conversion does not work. | ||
| return Ok(()); | ||
| } | ||
|
|
||
| // SAFETY: TODO SNP FUTURE: For defense in depth it could be useful to prevent |
There was a problem hiding this comment.
The PR description says this only removes stale TODO comments, but this hunk also removes the if value.vmsa() { return Ok(()); } early-return in rmpadjust_pages, which is a functional behavior change (VMSA adjustments will now be sent to the ioctl). Either restore the previous behavior or update the PR description (and rationale) to reflect the intentional behavior change.
| /// Execute the rmpadjust instruction on the specified memory range. | ||
| /// | ||
| /// The range must not be mapped in the kernel as RAM. | ||
| /// |
There was a problem hiding this comment.
The blank rustdoc line uses /// (with a trailing space). Please remove the trailing whitespace (use /// for a blank doc line) to avoid formatting/lint noise and keep diffs clean.
| /// | |
| /// |
1 participant
Remove a couple SNP TODO comments that are out of date.