Skip to content

feat: Add option to set output filename #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oliwheeler wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add option to set output filename #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f06146b
feat: Add option to set output filename
oliwheeler Oct 16, 2020
c812b5c
Change files
oliwheeler Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions change/p-profiler-2020-10-16-19-00-08-optional-out-file.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "minor",
"comment": "feat: Add option to set output filename",
"packageName": "p-profiler",
"email": "olwheele@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-10-16T17:00:08.686Z"
}
5 changes: 3 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export interface ProfilerOptions {
concurrency: number;
prefix: string;
outDir: string;
outFileName?: string;
}

export default class Profiler {
Expand All @@ -33,12 +34,12 @@ export default class Profiler {
private threads: number[];

constructor(opts: ProfilerOptions) {
const { concurrency, outDir, prefix } = opts;
const { concurrency, outDir, prefix, outFileName } = opts;

this.events = [];
this.outputPath = path.join(
path.resolve(outDir || "."),
getTimeBasedFilename(prefix)
outFileName ?? getTimeBasedFilename(prefix)
);
this.threads = range(concurrency);
}
Expand Down