fix(errorhandling): Filesystem check and error handling improvements #1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrawaliti
force-pushed
the
debugfs-fix
branch
from
d2ef0dc to
5985077
Compare
agrawaliti
changed the title
…ks in DNS and TCP retrans plugins Signed-off-by: Iti Agrawal <agrawaliti0107@gmail.com>
agrawaliti
force-pushed
the
debugfs-fix
branch
from
5985077 to
00ef41b
Compare
MikeZappa87
reviewed
Dec 9, 2025
| // CheckAndMountFilesystems checks if required filesystems are mounted. | ||
| // Returns an error if any required filesystem is not available. | ||
| // This helps prevent os.Exit() calls from dependencies that expect these filesystems. | ||
| func CheckAndMountFilesystems(l *log.ZapLogger) error { |
There was a problem hiding this comment.
How is this testable? Does it make sense to pass a slice of the types into this function? That way you would be able to write tests for each one of the scenarios below.
Contributor
Author
There was a problem hiding this comment.
Addressed them, Kept the list of fs constant in func, as its covering all the fspath for retina.
MikeZappa87
reviewed
Dec 9, 2025
| for _, fs := range filesystems { | ||
| var statfs unix.Statfs_t | ||
| for _, path := range fs.paths { | ||
| if err := unix.Statfs(path, &statfs); err != nil { |
There was a problem hiding this comment.
This seems odd, if unix.Statfs returns error we continue which could be missing files, permissions correct?
Contributor
Author
There was a problem hiding this comment.
Its checking all the path and if any required fs is not mounted it returns error, made the func more verbosed
agrawaliti
force-pushed
the
debugfs-fix
branch
2 times, most recently
from
f3a9a61 to
be4acce
Compare
Signed-off-by: Iti Agrawal <agrawaliti0107@gmail.com>
agrawaliti
force-pushed
the
debugfs-fix
branch
from
be4acce to
9fbd158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new mechanism to check and ensure required Linux filesystems are mounted before initializing plugins, improving error handling and preventing unexpected agent exits. The changes add a reusable function for filesystem checks and integrate it into the initialization logic of both the DNS and TCP retransmission plugins.
Filesystem check and error handling improvements:
CheckAndMountFilesystemsinpkg/plugin/common/filesystem_linux.goto verify and log the status of required filesystems (bpf,debugfs,tracefs) before plugin initialization, returning errors if critical filesystems are missing.pkg/plugin/dns/dns_linux.goandpkg/plugin/tcpretrans/tcpretrans_linux.goto callCheckAndMountFilesystemsin their respectiveInitmethods, logging errors and returning them to allow the agent to decide whether to continue or fail initialization. [1] [2]Code organization and dependencies:
commonpackage inpkg/plugin/tcpretrans/tcpretrans_linux.goto access the filesystem check functionality.fmtpackage import inpkg/plugin/dns/dns_linux.gofor error wrapping and formatting.# DescriptionPlease provide a brief description of the changes made in this pull request.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.~
new error logs:
ticket: #1711