Pass Activity ID through instrument #62
Conversation
|
@microsoft-github-policy-service agree company="Microsoft" |
|
@sivadeilra could you please review? |
|
Ahhh, sorry. This dropped off my radar. Could you sync to latest and rebase? I'll get to this ASAP after that. |
|
@sivadeilra Done |
win_etw_provider/src/guid.rs
Outdated
| } | ||
|
|
||
| #[cfg(feature = "uuid")] | ||
| impl From<&str> for GUID { |
There was a problem hiding this comment.
This needs to be TryFrom. From is for conversions that cannot fail.
If you want to have const constructors for GUID, then we need a different way to handle that. But From impls are expected not to panic.
|
Hey, thanks for rebasing. The only thing I think needs to be fixed is for the From impl to become a TryFrom impl. I'll be happy to merge this tomorrow with that fixed. |
|
@sivadeilra Thank you, good call. Fixed it. |
|
@sivadeilra could you please review? |
|
Sorry, I was out sick for about a week. Approved and merged. I'll get this published shortly. |
|
Published updates. Thanks for the contribution! |
2 participants
The code allows to pass Activity ID as one of the attributes in instruments.