Bug fix - fixed group member management errors with selecting new users, removing them, and updating the roles #608
+61
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l, group member role update, and approve/reject request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions in manage_groups.js are no longer global functions in the new version, so the actions fail in the manage group screen.
Trying to select a user after search results in this error where the fields do not populate (note, this works properly in public workspaces because those functions are still global functions).
Additionally, the Remove button does nothing when clicked, and attempting to update a member role also throws an error. The request approval/rejection workflow also needed to be fixed.
I updated the group member select code to more closely match the code in manage_public_workspace.js for consistency and moved the inline onclick handlers for the select-user-btn, remove-member-btn, change-role-btn, approve-request-btn, and reject-request-btn to event delegation blocks in the $(document).ready function.
After pushing this change, the updated buttons and functions work as expected.