Skip to content

fix: properly process result of extract() which is an object instead of array #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunilsurana merged 2 commits into from
Mar 25, 2025
Merged

fix: properly process result of extract() which is an object instead of array #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f84cf6
fix: properly process result of extract() which is an object instead …
Hotell Mar 12, 2025
619a38f
chore: bump version for release
Hotell Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "storywright",
"description": "Storybook setup.",
"license": "MIT",
"version": "0.0.27-storybook7.13",
"version": "0.0.27-storybook7.14",
"main": "lib/index.js",
"module": "lib/index.js",
"typings": "lib/index.d.ts",
Expand Down
6 changes: 3 additions & 3 deletions src/StoryWrightProcessor/GetStoriesV2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ getStoriesWithSteps();
function getStoriesWithSteps() {
return getPageStories().then((stories) => {
/**
* @type {typeof stories}
* @type {Array<import('../utils').Story>}
*/
const storiesWithSteps = [];
/**
* @type {string[]} story ids that failed while processing parameters
*/
const errors = [];
for (let story of stories) {
for (let story of Object.values(stories)) {
try {
const steps = story.parameters?.storyWright.steps;
if (Array.isArray(steps)) {
Expand All @@ -33,7 +33,7 @@ function getStoriesWithSteps() {

/**
*
* @returns {Promise<Array<import('../utils').Story>>}
* @returns {Promise<{[story_id:string]: import('../utils').Story}>}
*/
function getPageStories() {
return window["__STORYBOOK_PREVIEW__"].extract();
Expand Down