Skip to content

Harden HTTP proxy tests #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnstairs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Harden HTTP proxy tests #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cli/integrationtest/httpproxy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func TestHttpProxy(t *testing.T) {
t.Log("stdErr", stdErr)
}
require.Error(t, err, "curl should fail because the proxy is not used")
s.ShellExecSucceeds("tyger-proxy", fmt.Sprintf("curl --retry 5 --proxy %s --fail %s/metadata", squidProxy, tygerUrl))
s.ShellExecSucceeds("tyger-proxy", fmt.Sprintf("curl --retry 5 --retry-connrefused --retry-delay 1 --proxy %s --fail %s/metadata", squidProxy, tygerUrl))

// Specify the proxy via environment variable
s.ShellExecSucceeds("tyger-proxy", fmt.Sprintf("export HTTPS_PROXY=%s && tyger login -f /creds.yml --log-level trace && tyger buffer read %s > /dev/null", squidProxy, bufferId))
Expand Down Expand Up @@ -149,7 +149,7 @@ func TestHttpProxy(t *testing.T) {

_, _, err = s.ShellExec("tyger-proxy", fmt.Sprintf("curl --proxy %s --fail %s/metadata", squidProxy, tygerUrl))
require.Error(t, err, "curl should fail because the root CA certificates have been removed")
s.ShellExecSucceeds("tyger-proxy", fmt.Sprintf("curl --retry 5 --proxy %s --insecure --fail %s/metadata", squidProxy, tygerUrl))
s.ShellExecSucceeds("tyger-proxy", fmt.Sprintf("curl --retry 5 --retry-connrefused --retry-delay 1 --proxy %s --insecure --fail %s/metadata", squidProxy, tygerUrl))

// Use CA certificates that are embedded in the tyger binary
s.ShellExecSucceeds("tyger-proxy", "echo 'tlsCaCertificates: embedded' >> /creds.yml")
Expand Down
Loading