Skip to content

http-client-java, bug fix on mock value for BinaryData #9527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weidongxu-microsoft wants to merge 5 commits into
base: main
Choose a base branch
from
Open

http-client-java, bug fix on mock value for BinaryData #9527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1df4793
mock value for BinaryData
weidongxu-microsoft Jan 30, 2026
74f6a31
test
weidongxu-microsoft Jan 30, 2026
1c13b74
regen
weidongxu-microsoft Jan 30, 2026
6370720
.gitignore already has src/test/java/tsptest/**/arm*/generated
weidongxu-microsoft Jan 30, 2026
8937aac
changelog
weidongxu-microsoft Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...es/http-client-java_bug-fix-example-value-for-binary-data-2026-0-30-15-36-58.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@typespec/http-client-java"
---

Missing example value for BinaryData type in mock test.
2 changes: 1 addition & 1 deletion ...c/main/java/com/microsoft/typespec/http/client/generator/core/util/ModelTestCaseUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public static Object jsonFromType(int depth, IType type) {
return UUID.randomUUID().toString();
} else if (type == ClassType.URL) {
return "http://example.org/" + URLEncoder.encode(randomString(), StandardCharsets.UTF_8);
} else if (type == ClassType.OBJECT) {
} else if (type == ClassType.OBJECT || type == ClassType.BINARY_DATA) {
// unknown type, use a simple string
return "data" + randomString();
} else if (type instanceof EnumType) {
Expand Down
4 changes: 0 additions & 4 deletions packages/http-client-java/generator/http-client-generator-test/Generate.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,6 @@ $generateScript = {
} elseif ($tspFile -match "azure[\\/]resource-manager[\\/]multi-service-shared-models[\\/]") {
$tspOptions += " --option ""@typespec/http-client-java.metadata-suffix=shared-models"""
} elseif ($tspFile -match "tsp[\\/]arm.tsp") {
# for mgmt, do not generate tests due to random mock values
$tspOptions += " --option ""@typespec/http-client-java.generate-tests=false"""
# test service-name
$tspOptions += " --option ""@typespec/http-client-java.service-name=Arm Resource Provider"""
# also test generating from specific api-version
Expand All @@ -105,8 +103,6 @@ $generateScript = {
# enable client side validations
$tspOptions += " --option ""@typespec/http-client-java.client-side-validations=true"""
} elseif ($tspFile -match "tsp[\\/]arm-customization.tsp") {
# for mgmt, do not generate tests due to random mock values
$tspOptions += " --option ""@typespec/http-client-java.generate-tests=false"""
# add customization code
$tspOptions += " --option ""@typespec/http-client-java.customization-class=../../customization/src/main/java/KeyVaultCustomization.java"""
} elseif ($tspFile -match "tsp[\\/]arm-versioned.tsp") {
Expand Down
Loading
Loading