Get the direct dependencies while checking for promotion #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yezhu6
commented
Dec 16, 2025
yezhu6
commented
- add the tool id into the java upgrade prompts to specify the calling tool
- Change the getDependencies to getDirectDependencies to exclude the transitive dependencies
yezhu6
requested review from
chagong,
testforstephen and
wenytang-ms
as code owners
| } | ||
|
|
||
| // Check for parent pom in multi-module projects | ||
| const parentPomPath = path.join(path.dirname(pomPath), '..', 'pom.xml'); |
Contributor
There was a problem hiding this comment.
this may not be the fact. I think you can find all the pom.xml in this project first and then parse them one by one to find all the dependencies.
| /** | ||
| * Find the build file (pom.xml or build.gradle) for a project | ||
| */ | ||
| function findBuildFile(projectUri: string | undefined): { path: string; type: 'maven' | 'gradle' } | null { |
Contributor
There was a problem hiding this comment.
you can use "glob" to find the pom.xml files, remember to exclude certain folders to improve performance. you can find the usage of glob in vscode-java-upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.