Skip to content

Conversation

@GAM3RG33K
Copy link

@GAM3RG33K GAM3RG33K commented Dec 11, 2025

Package resolver should not depend on the package value from AndroidManifest.xml anymore, the latest android app configuration enforce adding the package name in app/build.gradle as applicationId.

Check latest documentation: https://developer.android.com/build/configure-app-module#set-application-id

Made following changes to deal with the issue:

  • Fixed package resolver code to detect applicationId in the app/build.gradle file before fallback to android manifest version
  • Added basic tests to verify the same changes

Package resolver should not depend on the package value from `AndroidManifest.xml` anymore, the latest android app configuration enforce adding the package name in app/build.gradle as `applicationId`

Made following changes to deal with the issue:
  - Fixed package resolver code to detect applicationId in the app/build.gradle file before fallback to android manifest version
   - Added basic tests to verify the same changes
@GAM3RG33K
Copy link
Author

@microsoft-github-policy-service agree

@GAM3RG33K
Copy link
Author

@ConnorQi01 Please review the PR.
Let me know if more details are required to get context about the bug or the fix

@ConnorQi01
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ConnorQi01
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ConnorQi01
Copy link
Collaborator

@GAM3RG33K
Hi, the CI "host tests" step failed with the following error:

ReferenceError: describe is not defined
    at Object.<anonymous> (/home/vsts/work/1/s/test/extension/android/packageNameResolver.test.js:19:1)

This usually happens when test files are executed outside of a proper test environment, so globals like describe are unavailable
. Common causes:

  • The test file is run directly with Node, not through Mocha or a suitable test runner.
  • The test entry script (e.g., runTest.js) does not correctly launch the test framework.
  • The test script in package.json or runner config is incorrect.

Suggestions:

  1. Check that CI invokes the test runner correctly (Mocha or the VSCode extension test runner).
  2. Try npm test locally to reproduce.
  3. Double-check your runTest.js, imports, and test script setup in package.json, and ensure consistency with other passing tests.

Feel free to share your runTest.js or config details if you need further help debugging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants