Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions generation/WinSDK/Partitions/WinProg/settings.rsp
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ _THREADINFOCLASS
_UNICODE_STRING
NtClose
NtCreateFile
NtCreateNamedPipeFile
NtDeviceIoControlFile
NtNotifyChangeMultipleKeys
NtOpenFile
Expand Down
28 changes: 24 additions & 4 deletions generation/WinSDK/RecompiledIdlHeaders/um/winternl.h
Original file line number Diff line number Diff line change
Expand Up @@ -450,10 +450,7 @@ NtClose (
IN HANDLE Handle
);

//
// use the Win32 API instead
// CreateFile
//

__kernel_entry NTSTATUS
NTAPI
NtCreateFile (
Expand Down Expand Up @@ -485,6 +482,29 @@ NtOpenFile (
IN ULONG OpenOptions
);

//
// use the Win32 API instead
// CreateNamedPipeA
//
Comment on lines +485 to +488
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment won't bubble up anywhere useful so you can delete it.

__kernel_entry NTSTATUS
NTAPI
NtCreateNamedPipeFile(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this file get clobbered the next time we run UpdateSDK with whatever is really in the SDK?

is this function definition available in a Windows SDK header that we could use / include instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs say it lives in ntioapi.h which isn't public. Agree, we should minimally move it to a new header (e.g., \generation\WinSDK\AdditionalHeaders\ntioapi.h)

OUT PHANDLE FileHandle,
IN ULONG DesiredAccess,
IN POBJECT_ATTRIBUTES ObjectAttributes,
OUT PIO_STATUS_BLOCK IoStatusBlock,
IN ULONG ShareAccess,
IN ULONG CreateDisposition,
IN ULONG CreateOptions,
IN ULONG NamedPipeType,
IN ULONG ReadMode,
IN ULONG CompletionMode,
IN ULONG MaximumInstances,
IN ULONG InboundQuota,
IN ULONG OutboundQuota,
IN PLARGE_INTEGER DefaultTimeout OPTIONAL
);

//
// use the Win32 API instead
// N/A
Expand Down