Develop #16
Merged
Develop #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (38 of 38 strings) Translation: MIKOPBX/ModulePhoneBook Translate-URL: https://weblate.mikopbx.com/projects/mikopbx/modulephonebook/ja/
Add SSRF protection by validating URL scheme (http/https only). Fix NULL pointer exceptions when Settings record doesn't exist. Fix Cyrillic 'С' in translation keys causing lookup failures. Remove duplicate callerId sanitization and skip API calls when URL not configured.
Fix critical bug where $result.getMessages() was called on boolean instead of record object. Add null check before accessing record properties in save action. Optimize mass delete to use direct SQL instead of iterating over records. Add type casting and empty row handling for Excel import. Remove duplicate search handler in datatable JS. Update Settings.php license header to GPL-3.0.
Rewrite README.md with improved structure: installation guide, usage examples, API integration docs, architecture overview, and database schema. Add README.ru.md with full Russian translation.
- Add cross-reference links between README.md and README.ru.md - Add detailed HTTP API request/response examples for caller ID lookup - Include examples with normalized phone numbers and plain text responses - Document caching behavior for external API integration
Replace manual Babel compilation commands with a Docker command in both English and Russian README files for improved clarity and ease of use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.