CLI: Support multiple tasks #196
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalende
reviewed
Jan 5, 2026
Member
lgalende
left a comment
lgalende
left a comment
There was a problem hiding this comment.
In general, we do:
if (...) something()
// or
if (...) {
somethingTooLongThatDoesNotFitOneLine()
}but not:
if (...)
somethingTooLongThatDoesNotFitOneLine()| const tasks = filterTasks(this, allTasks, include, exclude) | ||
| for (const task of tasks) { | ||
| console.log(`\n${log.highlightText(`[${task.name}]`)}`) | ||
| await this.runForTask(task, key, registryUrl, skipCompile, task.output) |
Member
There was a problem hiding this comment.
I don't quite get this, the inputDir param is the task.output?
| const tasks = filterTasks(this, allTasks, include, exclude) | ||
| for (const task of tasks) { | ||
| console.log(`\n${log.highlightText(`[${task.name}]`)}`) | ||
| await this.runForTask(task, key, registryUrl, skipCompile, task.output) |
Member
There was a problem hiding this comment.
For each task being deployed, all tasks are rebuilt repeatedly. This is O(n^2) and not necessary.
Member
There was a problem hiding this comment.
--exclude invest does not build invest but runs the Invest test. Is that the expected behavior, or should it run the Bridge test only?
Same with --include.
Devs can still use .only in their tests tho...
|
|
||
| const validNames = new Set(include.filter((name) => taskNames.has(name))) | ||
| if (validNames.size === 0) { | ||
| console.warn(`${log.warnText('Warning:')} No valid tasks to include. All tasks will be skipped.`) |
Member
There was a problem hiding this comment.
Should in the second case (i.e., when all tasks are excluded) also print Warning: No valid tasks to include. All tasks will be skipped.?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed:
mimic.yamlconfiguration file support for multi-taskMimicConfigHandlerto load and validatemimic.yamlconfigurations--includeand--excludeflags to all CLI commands for task filteringmimic.yamldoesn't exist