Skip to content

Conversation

@MinuraPunchihewa
Copy link
Contributor

@MinuraPunchihewa MinuraPunchihewa commented May 9, 2025

This PR updates the operations for interacting with Knowledge Bases based on the changes made to the REST APIs here.

Fixes https://linear.app/mindsdb/issue/UNI-49/update-sdk-methods-for-knowledge-bases

@MinuraPunchihewa MinuraPunchihewa marked this pull request as ready for review June 9, 2025 07:49
@MinuraPunchihewa MinuraPunchihewa requested a review from ea-rus June 9, 2025 07:49
@github-actions
Copy link

github-actions bot commented Jun 9, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sdk
   agents.py2115673%33, 101, 104, 107, 110, 118, 126, 146, 167, 178, 181, 185, 187, 189, 191, 193, 195, 257, 270, 281, 292, 296–311, 323, 332–336, 343–344, 392, 400–401, 454, 503–504, 507, 514, 535–537, 541–545
   databases.py49296%118, 146
   handlers.py39197%77
   jobs.py97793%40, 52, 80, 84, 146–149
   knowledge_bases.py1331589%70–73, 134, 160, 189, 196, 200–202, 206, 228–232, 242
   ml_engines.py42393%94, 126, 128
   models.py2101991%109, 140–141, 222, 231, 233, 303, 339, 348, 372, 397, 491, 499, 518, 534, 542, 567, 571, 584
   projects.py63198%160
   query.py13192%14
   skills.py53394%43, 45, 49
   tables.py1301588%140–142, 145, 165, 192, 203–204, 209, 224, 227, 321, 342–347, 356, 376
   views.py37295%105, 138
mindsdb_sdk/connectors
   rest_api.py2555280%19–29, 35–36, 51, 55, 58–59, 79–81, 102, 105, 112–115, 148–156, 177–178, 213–216, 230–231, 285–290, 294–306
mindsdb_sdk/utils
   agents.py50492%72, 79–81
   mind.py47470%1–128
   openai.py853065%37–40, 83–85, 107, 148–158, 215–216, 234–240, 258–276
   table_schema.py21210%1–54
TOTAL162227983% 

Tests Skipped Failures Errors Time
28 0 💤 0 ❌ 0 🔥 11.374s ⏱️

Copy link

@fshabashev fshabashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from to review to approved in Tracking PRs Jun 12, 2025
@MinuraPunchihewa MinuraPunchihewa merged commit 31f1e7a into main Jun 13, 2025
6 checks passed
@MinuraPunchihewa MinuraPunchihewa deleted the feature/update_kb_apis branch June 13, 2025 11:11
@github-project-automation github-project-automation bot moved this from approved to merged in Tracking PRs Jun 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: merged

Development

Successfully merging this pull request may close these issues.

3 participants