Skip to content

Conversation

@minorcell
Copy link
Owner

@minorcell minorcell commented Dec 21, 2025

✨ PR Description

Purpose: Internationalize memo-cli codebase by replacing Chinese text with English across system prompts, error messages, and documentation to improve accessibility for global developers.

Main changes:

  • Replaced Chinese system prompts and error messages with English equivalents in core runtime modules
  • Refactored assistant message parsing to remove legacy dual-format action support, keeping only direct tool format
  • Implemented idempotent session close with guard flag to prevent duplicate cleanup operations
  • Added new React-based TUI interface with interactive components, streaming output, and slash commands
  • Updated history message format to store structured JSON for tool calls instead of raw assistant text

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

… experience

- Updated `packages/ui/src/index.ts` to `packages/ui/src/index.tsx` for React compatibility.
- Implemented interactive and once-only modes in the CLI for better user engagement.
- Introduced session management and logging improvements with JSONL format.
- Added new components for rendering user and assistant messages, status updates, and command handling.
- Enhanced command parsing to support help, exit, clear, and tools listing.
- Created a structured UI with components for header, input prompt, main content, and token usage display.
- Improved session closing logic to prevent multiple closures.
- Added type definitions and utility functions for better type safety and code clarity.
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@minorcell minorcell changed the title feat feat: Added a TUI component to initially implement interaction Dec 21, 2025
@minorcell minorcell merged commit bd199b4 into main Dec 21, 2025
3 checks passed
@linearb linearb bot added the 1 min review label Dec 21, 2025
Copy link

@linearb linearb bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

The PR implements a comprehensive UI overhaul with TUI interface and language localization from Chinese to English. However, there are significant breaking changes in tool call parsing and history storage that could impact existing functionality.

2 issues detected:

🧹 Maintainability - Removing support for existing API format without deprecation could break existing integrations

Details: The removal of legacy action format support (nested "action" object) is a breaking change that could cause existing prompts or models using the old format to fail silently.
File: packages/core/src/utils/utils.ts

🐞 Bug - Changing the fundamental storage format of conversation history without considering backward compatibility

Details: The assistant message history storage format has changed significantly - now storing JSON for tool calls instead of raw assistant text. This could break history replay, token counting accuracy, and any code expecting the original assistant output format.
File: packages/core/src/runtime/session.ts

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants