Skip to content

Reduce the github_workflow_job_step_run_duration_seconds cardinality #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n-srg merged 1 commit into from
Sep 11, 2025
Merged

Reduce the github_workflow_job_step_run_duration_seconds cardinality #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pkg/actionsmetrics/event_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,7 @@ func (reader *EventReader) ProcessWorkflowJobEvent(ctx context.Context, event in
if *e.WorkflowJob.Conclusion == "success" && repoName == "client" {
for _, step := range e.WorkflowJob.Steps {
stepLabels := extraLabel("step_name", *step.Name, labels)
stepLabels["step_number"] = fmt.Sprint(step.Number)
stepLabels["step_conclusion"] = *step.Conclusion
stepLabels["step_status"] = *step.Status

stepDuration := step.CompletedAt.Sub(step.StartedAt.Time)

Expand Down
2 changes: 1 addition & 1 deletion pkg/actionsmetrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ func initGithubWorkflowJobStepDurationSeconds(buckets []float64) *prometheus.His
Help: "Run times for the steps in workflow jobs in seconds",
Buckets: buckets,
},
metricLabels("step_name", "step_number", "step_conclusion", "step_status"),
metricLabels("step_name", "step_conclusion"),
)
}

Expand Down
Loading