add traning status indicator icon, and warning notification #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
May 13, 2019
| /// <returns>True if required files exist, otherwise false.</returns> | ||
| private static bool Trained() | ||
| { | ||
| return File.Exists(Path.Combine(ThesaurusDirectory, "thesaurus_bayes.accord")) && |
Collaborator
There was a problem hiding this comment.
Let's make these file names res somewhere
Collaborator
|
Any reason why you prefer a blue check other than a green one? Other than this, looks fine to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses @johnpierson issue raised here: #9
This issue was addressed two fold:
Once the model has been properly trained the status icon would be reset to the following: