Skip to content

Add ability to set a parent element for the player #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacobroufa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ability to set a parent element for the player #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions source/shadowbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@
// Opacity for the overlay.
overlayOpacity: 0.5,

// Parent element for the overlay. This should be a DOM element.
parentElement: document.body,

// The index in the current gallery at which to start when first opening.
startIndex: 0

Expand Down Expand Up @@ -115,7 +118,7 @@
/**
* Appends Shadowbox to the DOM and initializes DOM references.
*/
function initialize() {
function initialize(parentElement) {
if (containerElement)
return; // Don't initialize twice!

Expand Down Expand Up @@ -145,7 +148,7 @@
var previousElement = makeDom("div", { id: "sb-prev" });

// Append #shadowbox to the DOM.
makeDom(document.body, [
makeDom(parentElement, [
makeDom(containerElement, [
overlayElement,
makeDom(wrapperElement, [
Expand Down Expand Up @@ -224,7 +227,7 @@
// Display the first item in the gallery, if there's anything left.
if (currentGallery.length > 0) {
if (currentIndex == -1) {
initialize();
initialize(currentOptions.parentElement);

if (isFunction(currentOptions.onOpen))
currentOptions.onOpen();
Expand Down