Adding tp_reachable #65
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new slot to the type that can provide a custom traversal for handling immutable/freezing of the code. Currently if this is not provided it falls back to tp_traverse.
This removes a special case from the code.
xFrednet
reviewed
Jan 19, 2026
Collaborator
xFrednet
left a comment
xFrednet
left a comment
There was a problem hiding this comment.
The addition itself looks good, but it doesn't set the tp_reachable for most built-in types. Once that is done it should be good to go.
Owner
Author
Sounds good. I mostly wanted to get someone else's eyes on it, and then we can decide how broad a blast radius we want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--65.org.readthedocs.build/