Semialgebraic complex plot and other plotting methods #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix plotting method in semialgebraic complex with concern to broken z order of parametric plot and region plot. added animated feature to semialgebraic complex plot
mkoeppe
reviewed
Sep 14, 2023
| super(BasicSemialgebraicSet_section, self).__init__(base_ring=base_ring, ambient_dim=ambient_dim, names=names, poly_ring=poly_ring) | ||
| self._upstairs_bsa = upstairs_bsa | ||
| self._polynomial_map = polynomial_map | ||
|
|
mkoeppe
reviewed
Sep 14, 2023
| gcd_c = gcd(gcd(coeff), c.inhomogeneous_term()) | ||
| t = sum(QQ(x)/gcd_c*y for x, y in zip(coeff, self.poly_ring().gens())) + QQ(c.inhomogeneous_term())/gcd_c | ||
| yield t | ||
| ## add tests |
Owner
There was a problem hiding this comment.
Why was this change (test for is_empty) necessary again? Is something wrong with the minimized_constraints?
Contributor
Author
There was a problem hiding this comment.
I don't remember exactly. I think it was there as a fix from before we knew that BasicSemialgebraicSet_section wasn't stable and when we had fixed that. I've done a few quick tests and it seems like the test for emptiness is not longer necessary.
Contributor
Author
There was a problem hiding this comment.
I've backed out those changes.
update plot method to use bsa that can prove emptiness fixing a plotting bug where semialgebraic complex would try to plot an empty set update NCC polyhedron to fix type error that happened when plot method was trying to plot an empty set.
ComboProblem
force-pushed
the
semialgebraic_complex_plot_and_other_plotting_methods
branch
from
40c58a9 to
1bdb425
Compare
Owner
|
please remove the ipynb files from the commits |
ComboProblem
force-pushed
the
semialgebraic_complex_plot_and_other_plotting_methods
branch
from
4f1355e to
1bdb425
Compare
Contributor
Author
|
I rolled back the changes that I had accidentally introduced. I forgot that I had done this until now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added animated flag to semialgebraic complex plot
fixed bugs with semialgebraic complex plot